889232 - Proxies set in add-on FoxyProxy bypassed after bug 887995 landed

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, defect)

Description

[JC Yang]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130701 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130701031115

Steps to reproduce:

1.Install latest nightly
2.Install foxyproxy 4.1.4
3.Configure foxyproxy to use proxy.


Actual results:

foxyproxy didn't work at all.


Expected results:

foxyproxy should work.

Comment 1

[Loic]

Did you contact the add-on author?

Do you see some error messages in the webconsole?

Comment 2

[JC Yang]

Yes, I've contact the author on irc and report in their forum.
No obvious related error messages in the browser console/web console.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

This should be handled by the developers. We don't track add-on bugs here, so please follow up with them.

Comment 4

[Shaddy Baddah]

I don't know whether this should be reopened, or a separate bug filed... but I have a strong claim that this is a regression introduced in Nightly.

The problem that I am seeing is that when using rule based proxies (based on patterns), if any proxy other than the catchall Default rule is encountered, proxying does not occur.

Also the logging is not complete.

This seems to have started with:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-29-03-11-16-mozilla-central/

and about:buildconfig shows:

http://hg.mozilla.org/mozilla-central/rev/c5ce065936fa

It is interesting to me anyway, to note that this is one build earlier than the first known bad for bug 888787,  "FoxyProxy toolbar button is rendered as a giant sprite sheet (with many icons)".

I'd consigned the general issues with FoxyProxy to the the lifespan of that bug. Now that that bug is resolved, I can confirm the problems reported here continue.

Comment 6

[Loic]

STR:see comment https://bugzilla.mozilla.org/show_bug.cgi?id=899544#c0

Regression range:
good=2013-06-28
bad=2013-06-29
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e3a124c9c1a&tochange=c5ce065936fa

Suspected bug:
Patrick McManus — bug 887995 - allow nsiprotocolproxyservice::asyncresolve() to be called re-entrantly bug 887995 - allow nsiprotocolproxyservice::asyncresolve() to be called re-entrantly r=jduell

Comment 7

[bhavana bajaj [:bajaj]]

Tracking as this might be a regression form bug 887995. Passing this onto Patrick to help with investigation ?

Comment 8

[lenmaer67]

Would really love if this could be fixed quickly.
People are paying money for proxy servers that can't be used any more with firefox.

Comment 9

[Patrick McManus [:mcmanus]]

Foxy Proxy appears to declare that it implements nsIProtocolProxyService2 but it does not actually implement the asyncResolve2() method of that IDL. That causes the failures.

imo the addon doesn't need to implement nsIProtocolProxySerivce2.. the http code checks whether that is implemented or not, and if not calls the old nsIProtocolProxyService::AsyncResolve() method. It did that for backwards compat - and the change of 887995 was definitely meant to be compatible with existing addons.

Eric, Georg, I'm suggesting that's a FP issue. what do you think?

Comment 10

[Georg Koppen]

(In reply to Patrick McManus [:mcmanus] from comment #9)
> Foxy Proxy appears to declare that it implements nsIProtocolProxyService2
> but it does not actually implement the asyncResolve2() method of that IDL.
> That causes the failures.

Indeed. I should have looked at your patch in bug 887995 and I would have seen that, sorry. I'll upload a bugfix version of FoxyProxy fixing this issue at the end of this week to AMO.

> imo the addon doesn't need to implement nsIProtocolProxySerivce2.. the http

Well, actually it needs to do so due to proxying plugin requests (we need to implement deprecatedBlockingResolve()).

> Eric, Georg, I'm suggesting that's a FP issue. what do you think?

I agree.

Comment 11

[Jason Duell]

So should this be an evangelism bug now?

Comment 12

[Georg Koppen]

(In reply to Jason Duell (:jduell) from comment #11)
> So should this be an evangelism bug now?

Not sure what you mean but that issue is fixed on FoxyProxy's side in version 4.2.2 (FoxyProxy Standard). User have verified that fix. I don't have the necessary privileges to close this bug, otherwise I would have done this already.

Comment 13

[Patrick McManus [:mcmanus]]

Georg - that's perfect feedback. Thanks!

marking wontfix because it was fixed outside of gecko.

Comment 14

[Patrick McManus [:mcmanus]]

this should not be tracked as it was an addon bug fixed outside of gecko