Closed Bug 889238 Opened 11 years ago Closed 11 years ago

[A/V] Try to play unsupported resolution of video file

Categories

(Firefox OS Graveyard :: General, defect, P1)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Milestone:
1.1 QE4 (15jul)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gecko, Assigned: sotaro)

References

Details

(Whiteboard: [TD-55494][LeoVB+])

Attachments

(3 files, 1 obsolete file)

test video file
4.17 MB, video/mp4
Details
patch v2 - add error handling to OMXCodecProxy
5.20 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
patch v2 for b2g18 - add error handling to OMXCodecProxy
5.20 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
Sometimes, video application list up unsupported resolution of video file.(more than 800x480) But there's an accurate step for reproducing it. 1. Send attached file from other device to leo via BT. 2. Try to play it by touching notification. It can be played but sometimes video frame disappear.
blocking-b2g: --- → leo+
Attached video test video file —
When OMXCodecProxy receives statusChanged callback, it compare video resolution with maximum resolution. It needs to fail then.. But It successfully create OMXCodec and returned. So next start() works successfully, also.
I'm not sure about video application case, because I cannot reproduce it. But sometimes, this file appear on the video application. I think sometimes it is successfully loaded.
Whiteboard: [TD-55494]
Assignee: nobody → sotaro.ikeda.g
Leo, did a crash in Bug 887527 happen during testing?
(In reply to Sotaro Ikeda [:sotaro] from comment #4) > Leo, did a crash in Bug 887527 happen during testing? This bug seems dup of Bug 887527. Error handling in OMXCodecProxy is not correct. Current code allow decoding even when the video is rejected because of the video size if hw codec decode it.
(In reply to Sotaro Ikeda [:sotaro] from comment #6) > Created attachment 770460 [details] [diff] [review] > patch - add error handling to OMXCodecProxy Leo, can you confirm if attachment 770460 [details] [diff] [review] fix the problem?
(In reply to Sotaro Ikeda [:sotaro] from comment #4) > Leo, did a crash in Bug 887527 happen during testing? Yep!! It's working.!!!
Attachment #770460 - Flags: review?(chris.double)
Blocks: 887527
Attachment #770460 - Flags: review?(chris.double) → review+
A patch for master. Carry "chris.double: review+".
Attachment #770460 - Attachment is obsolete: true
A patch for b2g18. Carry "chris.double: review+".
Attachment #771437 - Flags: review+
Attachment #771439 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5d5e8780e53b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [TD-55494] → [TD-55494][LeoVB+]
See Also: → 1064126
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: