88926 - use nsIMsgFolder::IsCommandEnabled() to clean up mail3PaneWindowCommands.js

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

use nsIMsgFolder::IsCommandEnabled() to clean up mail3PaneWindowCommands.js

spun off of bug #81321:

adding isCommandEnabled() to nsIMsgFolder allows us to clean up more of 
mail3PaneWindowCommands.js

instead of doing: (specialFolder == "Inbox" || specialFolder == "Trash" || 
isServer == "true")

you can add that check to nsMsgDBFolder::IsCommandEnabled() and check if the 
folder is the server and check the folder flags

we can clean up even more by implementing nsNewsFolder::IsCommandEnabled() to 
remove the checks against server type.

Comment 1

[Arun Prasannan (polar)]

This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/

Comment 2

[Mark Banner (:standard8)]

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.

Comment 3

[Philip Chee]

We seem to have nsIMsgFolder::IsCommandEnabled() and this has been in use since, um, a long time ago. Marking as WFM.