889352 - Remote debugging doesn't work if any tabs have no title

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[[e-mail]]

If a tab has no title then the debugger server falls back on asking the tabbrowser for the tab's title. However to do this it tries to call the _getTabForContentWindow function. If this does not exist then the debugging session fails. (I don't know whether the browser remains stable.)

Steps to reproduce problem:
1. Enable devtools.debugger.remote-enabled in about:config 
2. Install the debugger server enabler
3. Attempt to connect Firefox

Expected result: List of tabs is displayed

Actual result: Connection hangs

Comment 1

[[e-mail]]

Attachment: Proposed patch

While I was there I converted two handlers to use the method (which is a neatness improvement on the existing code).

Comment 2

[Philip Chee]

Comment on attachment 770166 [details] [diff] [review]
Proposed patch

>            const browsers = this.browsers;
>            if (browsers.length == 1)
>              return;
There is only one use of browsers so you might want to inline it e.g.
if (this.browsers.length == 1)

Comment 3

[[e-mail]]

Pushed comm-central changeset a6ac2d95f62d.

Comment 4

[[e-mail]]

Comment on attachment 770166 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 802081
User impact if declined: Can't debug when tabs have empty titles
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 5

[[e-mail]]

http://hg.mozilla.org/releases/comm-aurora/rev/8976b7efb6c7

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 770166 [details] [diff] [review]
Proposed patch

Review of attachment 770166 [details] [diff] [review]:
-----------------------------------------------------------------

a-CLOSED_TREE=me

Comment 7

[[e-mail]]

http://hg.mozilla.org/releases/comm-beta/rev/d4c1227b1eea