Closed Bug 889352 Opened 7 years ago Closed 7 years ago

Remote debugging doesn't work if any tabs have no title

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(seamonkey2.19 wontfix, seamonkey2.20 fixed, seamonkey2.21 fixed, seamonkey2.22 fixed)

RESOLVED FIXED
seamonkey2.22
Tracking Status
seamonkey2.19 --- wontfix
seamonkey2.20 --- fixed
seamonkey2.21 --- fixed
seamonkey2.22 --- fixed

People

(Reporter: neil, Assigned: neil)

References

()

Details

Attachments

(1 file)

If a tab has no title then the debugger server falls back on asking the tabbrowser for the tab's title. However to do this it tries to call the _getTabForContentWindow function. If this does not exist then the debugging session fails. (I don't know whether the browser remains stable.)

Steps to reproduce problem:
1. Enable devtools.debugger.remote-enabled in about:config 
2. Install the debugger server enabler
3. Attempt to connect Firefox

Expected result: List of tabs is displayed

Actual result: Connection hangs
Attached patch Proposed patchSplinter Review
While I was there I converted two handlers to use the method (which is a neatness improvement on the existing code).
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #770166 - Flags: review?(philip.chee)
Comment on attachment 770166 [details] [diff] [review]
Proposed patch

>            const browsers = this.browsers;
>            if (browsers.length == 1)
>              return;
There is only one use of browsers so you might want to inline it e.g.
if (this.browsers.length == 1)
Attachment #770166 - Flags: review?(philip.chee) → review+
Blocks: 890348
Pushed comm-central changeset a6ac2d95f62d.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
Comment on attachment 770166 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 802081
User impact if declined: Can't debug when tabs have empty titles
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #770166 - Flags: approval-comm-beta?
Attachment #770166 - Flags: approval-comm-aurora?
Attachment #770166 - Flags: approval-comm-beta?
Attachment #770166 - Flags: approval-comm-beta+
Attachment #770166 - Flags: approval-comm-aurora?
Attachment #770166 - Flags: approval-comm-aurora+
Comment on attachment 770166 [details] [diff] [review]
Proposed patch

Review of attachment 770166 [details] [diff] [review]:
-----------------------------------------------------------------

a-CLOSED_TREE=me
You need to log in before you can comment on or make changes to this bug.