Closed Bug 889361 Opened 11 years ago Closed 11 years ago

Stop choosing arbitrary global object in WebconsoleActor.

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 880511

People

(Reporter: ochameau, Unassigned)

Details

In various experiments (device support, simulators) about connecting tab actors to new targets, I often had to workaround the arbitrary selection of the global scope being done in WebConsoleActor:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/webconsole.js?force=1#68
The workaround was to always pass an iframe and never pass a global object.
I think that the parent actor should control the global object the webconsole is going to use. For example:
  this._window = aParentActor.contentWindow;
And even in the case of the global console, I think the parent actor should still control it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.