889365 - re-enable word cache expiration timers

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: re-enable the word cache expiration timer

In bug 717175, we disabled the timer-based expiration of shaped words from the per-font word caches, due to unexplained crashes on Windows.

It's possible that other fixes in the meantime may have resolved the underlying issue, which appeared to be possible hashtable corruption, but was never reproducible for proper diagnosis.

I'd like to try re-enabling the cache timers; fairly early in a Nightly cycle seems the best opportunity for this, so that we have the maximum time to watch for any problems that may arise.

Comment 1

[Jonathan Kew [:jfkthame]]

FWIW, I pushed this to tryserver (https://tbpl.mozilla.org/?tree=Try&rev=a6b980ffba92), but given that bug 717175 only showed up via crash-stats, not on TBPL, I doubt it'll really tell us much.

Comment 2

[Jonathan Kew [:jfkthame]]

Pushed to inbound; let's see if bug 717175 reappears:

https://hg.mozilla.org/integration/mozilla-inbound/rev/551c5e1f947d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/551c5e1f947d