Closed Bug 889512 Opened 6 years ago Closed 6 years ago

no focus event for google's moving textbox

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

when you start typeing into textbox at google.com then the textbox is destroyed and new one is created. There's no focus event for new textbox what is confusing for AT.

(was reported by AT vendor, marking blocking 2013q3a11y
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Attachment #771359 - Flags: review?(trev.saunders)
(don't forget to retest bug 775536 after this one)
I'd prefer this writen without using out args, any reason not to do that?
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> I'd prefer this writen without using out args, any reason not to do that?

what's bad about out args? doing a return value approach when it's not always needed doesn't seem nicer
(In reply to alexander :surkov from comment #4)
> (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> > I'd prefer this writen without using out args, any reason not to do that?
> 
> what's bad about out args? doing a return value approach when it's not
> always needed doesn't seem nicer

simpler and looks nicer, what's wrong with it? afaik we have plenty of other functions whose return value is sometimes ignored...
(In reply to Trevor Saunders (:tbsaunde) from comment #5)
> (In reply to alexander :surkov from comment #4)
> > (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> > > I'd prefer this writen without using out args, any reason not to do that?
> > 
> > what's bad about out args? doing a return value approach when it's not
> > always needed doesn't seem nicer
> 
> simpler and looks nicer, what's wrong with it? afaik we have plenty of other
> functions whose return value is sometimes ignored...

ok, if you like
on another hand out argument is used as a flag to avoid excess focus checks. Are you sure you want to replace that out arg on return value?
(In reply to alexander :surkov from comment #7)
> on another hand out argument is used as a flag to avoid excess focus checks.
> Are you sure you want to replace that out arg on return value?

I'm not sure, though don't we need to move more event logic (the popup stuff iirc) into CacheChildrenInsSubtree() so maybe we should add bool needEvents flag?
(In reply to Trevor Saunders (:tbsaunde) from comment #8)
> (In reply to alexander :surkov from comment #7)
> > on another hand out argument is used as a flag to avoid excess focus checks.
> > Are you sure you want to replace that out arg on return value?
> 
> I'm not sure, though don't we need to move more event logic (the popup stuff
> iirc) into CacheChildrenInsSubtree() so maybe we should add bool needEvents
> flag?

a small demo of idea? If it's code clean up only then maybe we could file a follow up on it since it's a major issue and the fix seems takes too long.
Comment on attachment 771359 [details] [diff] [review]
patch

ok whatever
Attachment #771359 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/2e7ae68148a6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.