Closed Bug 889515 Opened 7 years ago Closed 7 years ago

Get rid of sCurrentCompositor

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

(Whiteboard: [e10s])

Attachments

(1 file)

This breaks down when we have multiple windows.
Attachment #770337 - Flags: review?(nical.bugzilla)
Comment on attachment 770337 [details] [diff] [review]
Get rid of sCurrentCompositor

Review of attachment 770337 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorParent.cpp
@@ +680,5 @@
> +void
> +CompositorParent::NotifyChildCreated(uint64_t aChild)
> +{
> +  sIndirectLayerTrees[aChild].mParent = this;
> +}

Nit: Why not just put this line in RecvNotifyChildCreated ?
Attachment #770337 - Flags: review?(nical.bugzilla) → review+
(In reply to Nicolas Silva [:nical] from comment #1)
> Comment on attachment 770337 [details] [diff] [review]
> Get rid of sCurrentCompositor
> 
> Review of attachment 770337 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/ipc/CompositorParent.cpp
> @@ +680,5 @@
> > +void
> > +CompositorParent::NotifyChildCreated(uint64_t aChild)
> > +{
> > +  sIndirectLayerTrees[aChild].mParent = this;
> > +}
> 
> Nit: Why not just put this line in RecvNotifyChildCreated ?

Because the CrossProcessCompositorParent needs a function to call, I thought calling the RecvNotifyChildCreated version would be weird. The Recv*** functions are normally only called from auto-generated IPDL code.
ok, works for me
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a66fa3d6f6cb - 10.6 says (https://tbpl.mozilla.org/php/getParsedLog.php?id=25204404&tree=Mozilla-Inbound) "Assertion failure: lm->GetBackendType() == LAYERS_CLIENT, at ../../../layout/ipc/RenderFrameParent.cpp:608"
Other platforms did eventually chip in, including opt crashes in browser-chrome, it was just that 10.6 was firstest and most thorough about failing.
https://hg.mozilla.org/mozilla-central/rev/3e969b1777a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 897839
You need to log in before you can comment on or make changes to this bug.