Address bar context menu appear after second long tap

VERIFIED FIXED in Firefox 25

Status

()

Firefox for Android
Awesomescreen
VERIFIED FIXED
4 years ago
11 months ago

People

(Reporter: mkajda, Assigned: mkajda)

Tracking

25 Branch
Firefox 25
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130620123127

Steps to reproduce:

1. Enter some url into address bar and go to a web page.
2. Tap address bar once to select address
3. Long tap selected text
  - full context menu should appear at this point
  - only 'Paste' appear
4. Tap address again to deselect text
5. Long tap text again
  - now full context menu should appear


Actual results:

Full context menu (including 'Select all', 'Cut' 'Copy', 'Paste') appear for the second time. 


Expected results:

Full context menu should be displayed after first long tap.
(Assignee)

Updated

4 years ago
OS: Linux → Android
Hardware: x86_64 → ARM
(Assignee)

Comment 1

4 years ago
Android version 4.2.2
Model: Nexus 4

Reproducible on stable 22.0 and 25 built from repo.
(Assignee)

Comment 2

4 years ago
I can look into this issue with your help.
If you have any suggestions, please let me know.
On Chrome and stock browser, the context menu appears on first long tap. I've installed some older builds and the context menu appears only after the second tap( for example Firefox for Android 15)
Please find a regression-range.
tracking-fennec: --- → ?
Flags: needinfo?(teodora.vermesan)
Keywords: regression, regressionwindow-wanted
If on Firefox for Android 15 the same behaviour happens, shall I go deeper and install older builds and find the regression-range?
Flags: needinfo?(teodora.vermesan)
No. It would seem then that this has been around for some time then.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression, regressionwindow-wanted
(Assignee)

Comment 7

4 years ago
Could anyone assign bug to me please?
Thanks.
Assignee: nobody → michal.kajda
(Assignee)

Comment 8

4 years ago
I added some logs in onLongClick callback locally and it turned out that action bar's isShowing() method was returning true, when activity was created.
That's why it was not possible to draw the action bar until hide method was called for the first time from onSelectionChanged(int selStart, int selEnd) or afterTextChanged(final Editable s) callback.
https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/AwesomeBar.java#l251
https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/AwesomeBar.java#l742

After that, state of action bar was correct and subsequent long taps worked fine.
(Assignee)

Comment 9

4 years ago
Created attachment 771507 [details] [diff] [review]
Fixes action bar's behaviour

Brings action bar to valid state when activity is created
Attachment #771507 - Flags: review?(sriram)
(Assignee)

Comment 10

4 years ago
I'm still waiting for an access to try server, so patch was tested with my local build only.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Comment on attachment 771507 [details] [diff] [review]
Fixes action bar's behaviour

Review of attachment 771507 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Let this be next to "setContentView()" call.
Attachment #771507 - Flags: review?(sriram) → review+
Comment on attachment 771507 [details] [diff] [review]
Fixes action bar's behaviour

Review of attachment 771507 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. There should be a check for API version 11!
Attachment #771507 - Flags: review+ → review-
(Assignee)

Comment 13

4 years ago
Created attachment 772319 [details] [diff] [review]
Fixes action bar's behaviour

Corrected according to Sriram's comments.
It should be OK now.
Attachment #771507 - Attachment is obsolete: true
Attachment #772319 - Flags: review?(sriram)
Attachment #772319 - Flags: review?(sriram) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/40ae6894b21c
https://hg.mozilla.org/mozilla-central/rev/40ae6894b21c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25

Comment 16

4 years ago
Verified fixed on:
Build: Firefox for Android 25.0a1(2013-07-18)
Device: LG Nexus 4
OS: Android 4.2.2
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.