889686 - [Fig] GeckoBackgroundThread bookmarks crash - Java.lang.IllegalStateException: attempt to re-open an already-closed object

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Chenxia Liu [:liuche]]

2013-06-29-04-02-03-fig-android

Downloaded fig to factory reset 4.0.3 Google Nexus 4 phone, crashed on start.

Subsequent launch succeeded.

07-02 17:44:20.435: E/GeckoAppShell(1912): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 203 ("GeckoBackgroundThread")
07-02 17:44:20.435: E/GeckoAppShell(1912): java.lang.IllegalStateException: attempt to re-open an already-closed object: android.database.sqlite.SQLiteQuery (mSql = SELECT _id, url, title FROM combined WHERE ((url NOT IN (SELECT url FROM bookmarks WHERE bookmarks.parent == ? AND bookmarks.deleted == 0)) AND ((url NOT LIKE ?))) GROUP BY url ORDER BY (CASE WHEN bookmark_id > -1 THEN 100 ELSE 0 END) + visits * MAX(1, 100 * 225 / ((date - 1372812259473) / 86400000*(date - 1372812259473) / 86400000 + 225))  DESC LIMIT 6) 
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.sqlite.SQLiteClosable.acquireReference(SQLiteClosable.java:33)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.sqlite.SQLiteQuery.fillWindow(SQLiteQuery.java:82)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:164)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.sqlite.SQLiteCursor.onMove(SQLiteCursor.java:147)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:178)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.CursorWrapper.moveToPosition(CursorWrapper.java:162)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.CursorWrapper.moveToPosition(CursorWrapper.java:162)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.database.CursorWrapper.moveToPosition(CursorWrapper.java:162)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.db.BrowserDB$TopSitesCursorWrapper.moveToPosition(BrowserDB.java:390)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.db.BrowserDB$TopSitesCursorWrapper.moveToFirst(BrowserDB.java:436)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.home.TopBookmarksView$LoadThumbnailsTask.doInBackground(TopBookmarksView.java:352)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.home.TopBookmarksView$LoadThumbnailsTask.doInBackground(TopBookmarksView.java:343)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.util.UiAsyncTask$BackgroundTaskRunnable.run(UiAsyncTask.java:48)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.os.Handler.handleCallback(Handler.java:605)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.os.Handler.dispatchMessage(Handler.java:92)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at android.os.Looper.loop(Looper.java:137)
07-02 17:44:20.435: E/GeckoAppShell(1912): 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)
07-02 17:44:20.443: D/dalvikvm(1912): GC_CONCURRENT freed 543K, 5% free 14660K/15303K, paused 2ms+5ms
07-02 17:44:20.443: E/Gecko(1912): mozalloc_abort: Redirecting call to abort() to mozalloc_abort
07-02 17:44:21.357: I/WindowManager(189): WIN DEATH: Window{41a56f78 org.mozilla.fennec_fig/org.mozilla.fennec_fig.App paused=false}
07-02 17:44:21.357: I/ActivityManager(189): Process org.mozilla.fennec_fig (pid 1912) has died.
07-02 17:44:21.357: W/WindowManager(189): Force-removing child win Window{41a66c70 SurfaceView paused=false} from container Window{41a56f78 org.mozilla.fennec_fig/org.mozilla.fennec_fig.App paused=false}
07-02 17:44:21.357: W/ActivityManager(189): Force removing ActivityRecord{41a15728 org.mozilla.fennec_fig/.App}: app died, no saved state
07-02 17:44:21.365: W/WindowManager(189): Failed looking up window
07-02 17:44:21.365: W/WindowManager(189): java.lang.IllegalArgumentException: Requested window android.os.BinderProxy@419bb8b8 does not exist
07-02 17:44:21.365: W/WindowManager(189): 	at com.android.server.wm.WindowManagerService.windowForClientLocked(WindowManagerService.java:7163)
07-02 17:44:21.365: W/WindowManager(189): 	at com.android.server.wm.WindowManagerService.windowForClientLocked(WindowManagerService.java:7154)
07-02 17:44:21.365: W/WindowManager(189): 	at com.android.server.wm.WindowState$DeathRecipient.binderDied(WindowState.java:1545)
07-02 17:44:21.365: W/WindowManager(189): 	at android.os.BinderProxy.sendDeathNotice(Binder.java:417)
07-02 17:44:21.365: W/WindowManager(189): 	at dalvik.system.NativeStart.run(Native Method)
07-02 17:44:21.373: I/WindowManager(189): WIN DEATH: null
07-02 17:44:21.388: D/Zygote(119): Process 1912 exited cleanly (11)
07-02 17:44:21.459: W/InputManagerService(189): Got RemoteException sending setActive(false) notification to pid 1912 uid 10058

Comment 1

[Chenxia Liu [:liuche]]

Reproduced on another factory reset.

Fig claimed to have sent the crash report, but nothing shows up in about:crashes.

Comment 2

[Scoobidiver (away)]

(In reply to Chenxia Liu [:liuche] from comment #1)
> Fig claimed to have sent the crash report, but nothing shows up in
> about:crashes.
There are some at least: https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalStateException%3A+at+android.database.sqlite.SQLiteClosable.acquireReference%28SQLiteClosable.java%29

Comment 3

[:Margaret Leibovic]

I'm going to make this a blocker for merging fig back into m-c.

Comment 4

[Lucas Rocha (:lucasr)]

It seems like this crash is only happening on older fig builds. We are not using GeckoBackgroundThread anymore in the new about:home implementation. Closing for now. Feel free to re-open if you're still seeing this in the latest fig builds.