Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Implement MaskSurface in DrawTargetCairo

RESOLVED FIXED in mozilla25

Status

()

Core
Graphics
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jrmuizel, Assigned: James Kolb)

Tracking

unspecified
mozilla25
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 770559 [details] [diff] [review]
A sketch of what this could look like
(Reporter)

Comment 1

4 years ago
This is completely untested, may currently have problems with operators other than OVER and is perhaps missing a translation.
(Assignee)

Updated

4 years ago
Blocks: 603488
(Reporter)

Comment 2

4 years ago
James, feel free to finish this patch up if you're interested.
(Assignee)

Comment 3

4 years ago
Will do.
(Assignee)

Comment 4

4 years ago
Created attachment 771112 [details] [diff] [review]
Patch: Implement MaskSurface in DrawTargetCairo

This is a fixed up version of Jeff's sketch.
Attachment #771112 - Flags: review?(bas)
Comment on attachment 771112 [details] [diff] [review]
Patch: Implement MaskSurface in DrawTargetCairo

Review of attachment 771112 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me as far as I can tell, has it been tested?
Attachment #771112 - Flags: review?(bas) → review+
(Assignee)

Comment 6

4 years ago
I can confirm that it allows gfxContext::Mask to perform the same as the old version from before it used MaskSurface.

Is there an additional set of tests I should run on it? I'm not sure if it works for all the different possible uses of MaskSurface, but it probably can't be any worse than MOZ_ASSERT(0).
(Assignee)

Comment 7

4 years ago
Can somebody check this in when they get a chance? I don't have access to check it in or change the keywords to add "checkin-needed".
(Reporter)

Comment 8

4 years ago
(In reply to James Kolb from comment #7)
> Can somebody check this in when they get a chance? I don't have access to
> check it in or change the keywords to add "checkin-needed".
Keywords: checkin-needed
Attachment #770559 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf0646465523
Assignee: nobody → jck1089
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf0646465523
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.