889693 - Implement MaskSurface in DrawTargetCairo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: A sketch of what this could look like

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This is completely untested, may currently have problems with operators other than OVER and is perhaps missing a translation.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

James, feel free to finish this patch up if you're interested.

Comment 3

[James Kolb]

Will do.

Comment 4

[James Kolb]

Attachment: Patch: Implement MaskSurface in DrawTargetCairo

This is a fixed up version of Jeff's sketch.

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 771112 [details] [diff] [review]
Patch: Implement MaskSurface in DrawTargetCairo

Review of attachment 771112 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me as far as I can tell, has it been tested?

Comment 6

[James Kolb]

I can confirm that it allows gfxContext::Mask to perform the same as the old version from before it used MaskSurface.

Is there an additional set of tests I should run on it? I'm not sure if it works for all the different possible uses of MaskSurface, but it probably can't be any worse than MOZ_ASSERT(0).

Comment 7

[James Kolb]

Can somebody check this in when they get a chance? I don't have access to check it in or change the keywords to add "checkin-needed".

Comment 8

[Jeff Muizelaar [:jrmuizel]]

(In reply to James Kolb from comment #7)
> Can somebody check this in when they get a chance? I don't have access to
> check it in or change the keywords to add "checkin-needed".

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf0646465523

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf0646465523