Closed Bug 889699 Opened 6 years ago Closed 6 years ago

Erroneously reports being able to play h264 with gstreamer backend.

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: ajones, Assigned: eflores)

References

Details

Attachments

(1 file)

Needs to check not only that gstreamer is installed but that gstreamer can play h264 and report the canPlayType correctly. See bug 887137 causing confusion.
Maybe some web console logging or other UI would help here too.
Assignee: nobody → edwin
Status: NEW → ASSIGNED
Attached patch FixSplinter Review
Attachment #776134 - Flags: review?(alessandro.d)
Comment on attachment 776134 [details] [diff] [review]
Fix

Review of attachment 776134 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks!

::: content/media/gstreamer/GStreamerFormatHelper.cpp
@@ +145,5 @@
> +
> +      if (!tmp) {
> +        gst_caps_unref(caps);
> +        continue;
> +      }

This can only happen if there's a typo in sDefaultCodecCaps[i][1] right? If so please remove it since it's defensive code that can mask bugs.
Attachment #776134 - Flags: review?(alessandro.d) → review+
https://hg.mozilla.org/mozilla-central/rev/e11fd10615c7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.