Closed Bug 889720 Opened 7 years ago Closed 7 years ago

Media Recording - implement Pause/Resume DOM API

Categories

(Core :: Audio/Video: Recording, defect)

x86_64
All
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla25

People

(Reporter: rlin, Assigned: rlin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

The Bug: 803414 [Audio Recording - Web API & Implementation] just implement the start/stop function. We want to support pause/resume function also.
Assignee: nobody → rlin
Summary: Audio Recording - implement pause/resume → Audio Recording - implement Pause/Resume DOM API
Attached patch patch v1 (obsolete) — Splinter Review
Using ChangeExplicitBlockerCount to simulate the pause/resume DOM API.
Attachment #771952 - Flags: review?(roc)
Summary: Audio Recording - implement Pause/Resume DOM API → Media Recording - implement Pause/Resume DOM API
Comment on attachment 771952 [details] [diff] [review]
patch v1

Review of attachment 771952 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/MediaRecorder.cpp
@@ +172,5 @@
>    }
> +
> +  // Create a TrackUnionStream to support Pause/Resume by using ChangeExplicitBlockerCount
> +  MediaStreamGraph* gm = MediaStreamGraph::GetInstance();
> +  mTrackUnionStream = gm->CreateTrackUnionStream(mStream);

Use mStream->GetStream()->Graph() instead of calling MediaStreamGraph::GetInstance.

@@ +389,5 @@
> +  // Avoid crash on closing the browser during record.
> +  if (!GetOwner() || !mTrackUnionStream->GetWrapper())
> +    return false;
> +
> +  nsCOMPtr<nsIPrincipal> principal = mTrackUnionStream->GetWrapper()->GetPrincipal();

I think you can keep using mStream->GetPrincipal().
Attached patch patch v2 (obsolete) — Splinter Review
Fix nits.
Attachment #771952 - Attachment is obsolete: true
Attachment #771952 - Flags: review?(roc)
Attachment #775304 - Flags: review?(roc)
Attached patch check-in patchSplinter Review
carry reviewer roc.
Attachment #775304 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/1990b3e75ab8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Keywords: verifyme
QA Contact: jsmith
No longer blocks: 803414
Verified that smoketests of this feature are passing.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Component: Video/Audio → Video/Audio: Recording
No longer blocks: MediaRecording
You need to log in before you can comment on or make changes to this bug.