Closed Bug 889730 Opened 8 years ago Closed 8 years ago
Channel Manager] Get Headphones API should return true when state is headphone or headset .
In AudioChannelManager::Notify(), the true of headset state will depend on ON/HEADPHONE/HEADSET and this is correct. But in AudioChannelManager::GetHeadphones(), it just judged the state by "ON" only. The real case is that GonkSwitch will notify event with off/headset/headphone values.
The issue in this bug is that the headphone status is judged by statement as below. "return mState == hal::SWITCH_STATE_ON;" But actually the switch states for headphone would be SWITCH_STATE_OFF, SWITCH_STATE_HEADSET, // Headphone with microphone SWITCH_STATE_HEADPHONE, // without microphone So the return value will always be false.
Attachment #770707 - Flags: review?(amarchesini)
This will effect the engineering mode test on helix project.
blocking-b2g: --- → hd?
Comment on attachment 770707 [details] [diff] [review] Patch v1 Review of attachment 770707 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #770707 - Flags: review?(amarchesini) → review+
bumping to leo? for Mozilla triage - as a discussion with Marco indicates this is generic, although found while assessing helix's needs but it impacts the correctness of a WebAPI.
blocking-b2g: hd? → leo?
Triage - partners will take this for leo.
blocking-b2g: leo? → leo+
To add reviewer name and leo+ approval.
Backed out for B2G debug build bustage. https://hg.mozilla.org/projects/birch/rev/1b93158f0bf7 https://tbpl.mozilla.org/php/getParsedLog.php?id=25326133&tree=Birch
To fix the compile error on B2G debug mode. Sorry to make this trouble.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Needs a branch-specific patch for uplift.
Target Milestone: --- → 1.1 QE4 (15jul)
Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?
You need to log in before you can comment on or make changes to this bug.