889750 - [Settings] No action when pressed back key after select Firefox OS privacy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Leo]

1. Title : No action when pressed back key after select Firefox OS privacy
2. Precondition : 
3. Tester's Action : Settings - Device information - Your Privacy - Firefox OS - Load the page on browser - long home key - reopen Settings app - click back button
4. Detailed Symptom : No action
5. Expected : Go to the previous page
6. Reproducibility: Y
   - Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8. Version Info
Build ID : 20130616070209
GAIA : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
GECKO : be276cf55ce160bca09f36d9ca679a2ae20ea7cc

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

I had added a checking code to prevent change contentpanel when url href is "#" which is changed by [1] when the link is an external link.

[1] https://github.com/mozilla-b2g/gaia/blob/ced5b77eeb1eab1decacf3d461ddcf7d01df6a4d/apps/settings/js/settings.js#L236

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 771141 [details]
patch for this bug

John, good work. r=me. Before merging please add a comment describing the rationale of the modification. Thanks!

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/e9a0008da67068c1787e58700c0b4dae2e107164

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e9a0008da67068c1787e58700c0b4dae2e107164 to:
v1-train: cd854cb3f8da4c620449dba5436525950800c3ec

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: cd854cb3f8da4c620449dba5436525950800c3ec