Closed Bug 889750 Opened 7 years ago Closed 7 years ago

[Settings] No action when pressed back key after select Firefox OS privacy

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE4 (15jul)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: johnhu)

Details

(Whiteboard: [TD-56714][LeoVB+])

Attachments

(1 file)

1. Title : No action when pressed back key after select Firefox OS privacy
2. Precondition : 
3. Tester's Action : Settings - Device information - Your Privacy - Firefox OS - Load the page on browser - long home key - reopen Settings app - click back button
4. Detailed Symptom : No action
5. Expected : Go to the previous page
6. Reproducibility: Y
   - Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8. Version Info
Build ID : 20130616070209
GAIA : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
GECKO : be276cf55ce160bca09f36d9ca679a2ae20ea7cc
blocking-b2g: --- → leo+
Priority: -- → P1
Whiteboard: [TD-56714]
Target Milestone: --- → 1.1 QE4 (15jul)
Assignee: nobody → johu
Attached file patch for this bug
I had added a checking code to prevent change contentpanel when url href is "#" which is changed by [1] when the link is an external link.

[1] https://github.com/mozilla-b2g/gaia/blob/ced5b77eeb1eab1decacf3d461ddcf7d01df6a4d/apps/settings/js/settings.js#L236
Attachment #771141 - Flags: review?(arthur.chen)
Comment on attachment 771141 [details]
patch for this bug

John, good work. r=me. Before merging please add a comment describing the rationale of the modification. Thanks!
Attachment #771141 - Flags: review?(arthur.chen) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/e9a0008da67068c1787e58700c0b4dae2e107164
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted e9a0008da67068c1787e58700c0b4dae2e107164 to:
v1-train: cd854cb3f8da4c620449dba5436525950800c3ec
Whiteboard: [TD-56714] → [TD-56714][LeoVB+]
v1.1.0hd: cd854cb3f8da4c620449dba5436525950800c3ec
You need to log in before you can comment on or make changes to this bug.