889960 - Failing to log in when prompted redirects to /login/ which is broken

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

If you go to a page like, /report/exploitability/ when you're NOT logged in it will redirect you to /login/ which doesn't exist.

Comment 1

[Brandon Savage [:brandon]]

While I could reproduce this at file time, it cannot be reproduced at this time in the webapp.

Comment 2

[Peter Bengtsson [:peterbe]]

How you could not reproduce it I don't know. Perhaps something is lost in translation. 

Here's another way of seeing it::

 $ curl -v https://crash-stats.mozilla.com/report/exploitability/
 < HTTP/1.1 302 FOUND
 < Date: Fri, 16 Aug 2013 15:53:57 GMT
 < Server: Apache
 < Vary: X-Mobile,User-Agent,Cookie,Accept-Encoding
 < X-Frame-Options: DENY
 < Location: https://crash-stats.mozilla.com/login/?next=/report/exploitability/
 ...

 $ curl -v https://crash-stats.mozilla.com/login/?next=/report/exploitability/ > /dev/null
 < HTTP/1.1 404 NOT FOUND
 < Date: Fri, 16 Aug 2013 15:55:30 GMT
 < Server: Apache
 ...

Comment 3

[Brandon Savage [:brandon]]

Aha, my bad, I was logged in. Thanks, I will look into this.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b32aa95dc603cf1dde29155f745a8b7ce552a761
Fixes Bug 889960 - Adds a login page so the user doesn't get a 404.

https://github.com/mozilla/socorro/commit/5c6647c8a8678c371b65f80e3576a9de6e60bf24
Merge pull request #1407 from brandonsavage/bug889960login

Fixes Bug 889960 - Adds a login page so the user doesn't get a 404.

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa_screenshot_of_fix.png

Reopening:
I don't fully like this solution .. adding helper text that a user must read + scrolling to the login button at the bottom of the page seems suboptimal (think RSI). I would prefer a login button be added to the body of the page, even it means redundancy with the footer.

Reopening and adding a need more info, peterbe what is the expected behavior for the login page that you had in mind?

Comment 6

[Peter Bengtsson [:peterbe]]

:mbrandt,
It's a fair point. Having to read instructions suck. 
Mind you though, you only ever get to this page if you try to reach a bookmarked URL that points to a restricted page. There's nothing you can click that will make you end up on this page. 
In other words, it's a rare occurrence anyway. 

I honestly didn't have an expected behavior in mind. I just didn't want a Page Not Found page :)

Personally, I'm happy with it the way it is. It's not very pretty but the use case is quite rare and only the likes of devs or KaiRo should really see it.

Comment 7

[Brandon Savage [:brandon]]

I agree with peterbe. Bumping back to resolved per IRC discussion with mbrandt.

Comment 8

[Matt Brandt [:mbrandt]]

Thanks :peterbe and :brandon. I agree it is a very small population of people who would ever hit the /login/ page. 

Bumping to qa verified per reasons enumerated in comment 6.