890137 - [Australis] Menu should appear on mousedown, not mouseup

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement)

Description

[Jesse Ruderman]

UX 25.0a1 (2013-07-02)

It should be possible to use the Australis Menu with a single click-drag motion, rather than one click to open the menu and one click on a button.

Comment 1

[Jesse Ruderman]

Thunderbird almost gets this right. See bug 890332.

Comment 2

[Jesse Ruderman]

Gijs points out that the same problem affects the Downloads button.  So maybe this is a pre-existing bug made much worse by Australis, rather than a bug in Australis code.

Comment 3

[Justin Dolske [:Dolske]]

Hmmmmmm. I am really tempted to take this off the Australis list (since all existing doorhangers work this way), but I'd like to think this should be an easy fix for additional snappyness. Should that not be the case, I think we have to skip it.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 795708 [details] [diff] [review]
Patch

Hm - this is a fine idea, but I'm noticing this causes strange behaviour when clicking on the menu button in customization mode. While this used to cause an exit of customization mode, now it causes an empty panel to appear on mouse down, and then exit on mouse up. It's even weirder with restored windows (at least on Windows 7), with the panel getting re-populated after mouse-up, but the panel being detached from the window.

So I'd suggest looking into the click handler for the menu button in customization mode as well, and making sure that operates on mouse down.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

This fixes the bug when exiting customization mode.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 800930 [details] [diff] [review]
Patch v2

The code looks good, and mouse interaction is great (yeah, this just feels much snappier!).

But keyboard interaction seems busted. If I hit Ctrl-m to open the menu, the panel opens in the middle of the browser, anchored to what appears to be the titlebar:

http://i.imgur.com/gNmk8UO.png

Can you check out what's going on there?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2.1

I should have left the handling for aEvent.type == "command" on there as that is the type of event that is used for the Ctrl+M shortcut.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 805672 [details] [diff] [review]
Patch v2.1

Ok, let's roll with this. Thanks jaws!

Comment 10

[Mike de Boer [:mikedeboer]]

landing-ping!

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/880516d00bfa

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/880516d00bfa