[Australis] Menu should appear on mousedown, not mouseup

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Menus
--
enhancement
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jesse Ruderman, Assigned: jaws)

Tracking

(Blocks: 1 bug, {ux-efficiency})

Trunk
Firefox 28
ux-efficiency
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [parity-chrome][Australis:P3][Australis:M9])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
UX 25.0a1 (2013-07-02)

It should be possible to use the Australis Menu with a single click-drag motion, rather than one click to open the menu and one click on a button.
(Reporter)

Comment 1

5 years ago
Thunderbird almost gets this right. See bug 890332.
(Reporter)

Comment 2

5 years ago
Gijs points out that the same problem affects the Downloads button.  So maybe this is a pre-existing bug made much worse by Australis, rather than a bug in Australis code.
Hmmmmmm. I am really tempted to take this off the Australis list (since all existing doorhangers work this way), but I'd like to think this should be an easy fix for additional snappyness. Should that not be the case, I think we have to skip it.
Whiteboard: [parity-chrome] → [parity-chrome][Australis:P3]
Created attachment 795708 [details] [diff] [review]
Patch
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #795708 - Flags: review?(mconley)
OS: Mac OS X → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 795708 [details] [diff] [review]
Patch

Hm - this is a fine idea, but I'm noticing this causes strange behaviour when clicking on the menu button in customization mode. While this used to cause an exit of customization mode, now it causes an empty panel to appear on mouse down, and then exit on mouse up. It's even weirder with restored windows (at least on Windows 7), with the panel getting re-populated after mouse-up, but the panel being detached from the window.

So I'd suggest looking into the click handler for the menu button in customization mode as well, and making sure that operates on mouse down.
Attachment #795708 - Flags: review?(mconley) → review-
Created attachment 800930 [details] [diff] [review]
Patch v2

This fixes the bug when exiting customization mode.
Attachment #795708 - Attachment is obsolete: true
Attachment #800930 - Flags: review?(mconley)
Comment on attachment 800930 [details] [diff] [review]
Patch v2

The code looks good, and mouse interaction is great (yeah, this just feels much snappier!).

But keyboard interaction seems busted. If I hit Ctrl-m to open the menu, the panel opens in the middle of the browser, anchored to what appears to be the titlebar:

http://i.imgur.com/gNmk8UO.png

Can you check out what's going on there?
Attachment #800930 - Flags: review?(mconley)
Created attachment 805672 [details] [diff] [review]
Patch v2.1

I should have left the handling for aEvent.type == "command" on there as that is the type of event that is used for the Ctrl+M shortcut.
Attachment #800930 - Attachment is obsolete: true
Attachment #805672 - Flags: review?(mconley)
Comment on attachment 805672 [details] [diff] [review]
Patch v2.1

Ok, let's roll with this. Thanks jaws!
Attachment #805672 - Flags: review?(mconley) → review+
landing-ping!
https://hg.mozilla.org/projects/ux/rev/880516d00bfa
Whiteboard: [parity-chrome][Australis:P3] → [parity-chrome][Australis:P3][Australis:M9][fixed-in-ux]

Updated

4 years ago
Depends on: 936633

Comment 12

4 years ago
https://hg.mozilla.org/mozilla-central/rev/880516d00bfa
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [parity-chrome][Australis:P3][Australis:M9][fixed-in-ux] → [parity-chrome][Australis:P3][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.