890153 - Defect -OSK overlapping searched words using "Find in Page" if website not scrollable

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

If you search for words using the "Find in Page" under "Settings" on a website that is not scrollable (Google), the OSK will overlap and hide anything that is found behind it.

Steps to reproduce the issue: (try not use a mouse)

1) Open Firefox Metro
2) Tap on the "Navigation App Bar" and tap in google.com
3) Select "Settings" -> "Find in Page" under the "Navigation App Bar" once Google has loaded
4) Type in "google" using the OSK and select the "Up" and "Down" arrows (Notice that when it goes to the bottom of the website, the OSK is blocking the searched words)

Current Behavior:

- OSK is currently overlapping searched words if the website is not scrollable

Expected Behavior:

- Users should be able to go through searched words without the OSK overlapping words. Maybe we can dismiss the OSK when a user selects "up" or "down" and slide it back in if they select the "search box" again

Comment 1

[Jim Mathies [:jimm]]

Potential fix: remove focus from the input to hide the keyboard, vs. shifting the browser up which is more complex to pull off.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 780974 [details] [diff] [review]
fix

Testable now that the parent bug is fixed.

Comment 4

[Marco Mucci [:MarcoM]]

Hey Jim, what point value estimate would you like to assign to this defect?

Comment 5

[Jim Mathies [:jimm]]

Attachment: export patch

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/e71d2789a994

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e71d2789a994

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-13-03-02-05-mozilla-central/

- Went through the original issue from comment #0 without any issues (Both Google & Bing)
- Tried several other websites such as Wikipedia, Facebook, Twitter and ensured the behavior and experience is the same
- Went through all of the test cases using Field View without any issues

Found an issue that is none related and created a bug (button state always appears highlighted)

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #13 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-09-03-02-04-mozilla-central/

- Went through the original test case added in comment #0 without any issues
- Went through the test cases added in comment #8 without any issues

I am still seeing Bug 905808 occurring (Enter on the keyboard and the OSK are not working correctly)