Closed Bug 890153 Opened 7 years ago Closed 7 years ago

Defect -OSK overlapping searched words using "Find in Page" if website not scrollable

Categories

(Firefox for Metro Graveyard :: Input, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: kjozwiak, Assigned: jimm)

References

Details

(Whiteboard: feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=1)

Attachments

(1 file, 1 obsolete file)

If you search for words using the "Find in Page" under "Settings" on a website that is not scrollable (Google), the OSK will overlap and hide anything that is found behind it.

Steps to reproduce the issue: (try not use a mouse)

1) Open Firefox Metro
2) Tap on the "Navigation App Bar" and tap in google.com
3) Select "Settings" -> "Find in Page" under the "Navigation App Bar" once Google has loaded
4) Type in "google" using the OSK and select the "Up" and "Down" arrows (Notice that when it goes to the bottom of the website, the OSK is blocking the searched words)

Current Behavior:

- OSK is currently overlapping searched words if the website is not scrollable

Expected Behavior:

- Users should be able to go through searched words without the OSK overlapping words. Maybe we can dismiss the OSK when a user selects "up" or "down" and slide it back in if they select the "search box" again
Priority: -- → P2
Potential fix: remove focus from the input to hide the keyboard, vs. shifting the browser up which is more complex to pull off.
No longer blocks: 867641
Attached patch fix (obsolete) — Splinter Review
Depends on: 897941
Depends on: 897590
No longer depends on: 897941
Comment on attachment 780974 [details] [diff] [review]
fix

Testable now that the parent bug is fixed.
Attachment #780974 - Flags: review?(ally)
Hey Jim, what point value estimate would you like to assign to this defect?
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Whiteboard: feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0 → feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=1
Assignee: nobody → jmathies
Blocks: metrov1it12
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Attachment #780974 - Flags: review?(ally) → review+
Attached patch export patchSplinter Review
Attachment #780974 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e71d2789a994
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-13-03-02-05-mozilla-central/

- Went through the original issue from comment #0 without any issues (Both Google & Bing)
- Tried several other websites such as Wikipedia, Facebook, Twitter and ensured the behavior and experience is the same
- Went through all of the test cases using Field View without any issues

Found an issue that is none related and created a bug (button state always appears highlighted)
Depends on: 905808
Went through the following "Defect" for iteration #13 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-09-03-02-04-mozilla-central/

- Went through the original test case added in comment #0 without any issues
- Went through the test cases added in comment #8 without any issues

I am still seeing Bug 905808 occurring (Enter on the keyboard and the OSK are not working correctly)
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.