890163 - URL bar autocomplete misbehaves for file and ftp URIs

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Make sure /tmp/test.html exists
2)  Start browser with new profile
3)  Type "file:///tmp/test.html" into the URL bar and hit enter
4)  Hit Cmd-L
5)  Type "file"

EXPECTED RESULTS:  URL bar shows "file"

ACTUAL RESULTS: URL bar shows "file//" with the caret right after the 'e'

Regression range on m-c nightlies: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3b955f306226&tochange=8e3a124c9c1a

Marco, could bug 791776 have caused this?

Comment 1

[Marco Bonardo [:mak]]

I can reproduce the problem, it's possible the async behavior is causing this strange behavior, I will try to debug it and see.

Comment 2

[Marco Bonardo [:mak]]

Can reproduce also with ftp

Comment 3

[Marco Bonardo [:mak]]

I think I figured the patch introduced a difference in the code behavior, that was not intended. I will make a patch and a test for it.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.0

In the async patch I misinterpreted the code behavior, so while cleaning up a bit the code I ended up changing a condition that was untested :(
The original behavior was that if the search string does not contain a slash, then we just search for hosts, otherwise, if the slash is not the last char, we query for a url.
I mischanged it so that if we don't find a matching host we try to match on the url. This was not intended and as such should be reverted. The patch restores the original behavior, and adds a test that would catch this.

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bfb7976d549

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6bfb7976d549