890279 - Create ScrollInfoLayers for frames we want APZC support

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Follow up to bug 775459 since it didn't really fit in there.

Carrying r=kats,mattwoodrow . Patch should be ready to go once I fix the assertion in dom/indexedDB/ipc:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24842027&tree=Try

Comment 1

[Benoit Girard (:BenWa)]

My code is trying to build a nsScrollInfoLayer to hold the scroll meta data but it's hitting this assertion. Looks like we can either:
1) Change the layer type to LAYER_ACTIVE and remove the _EMPTY part or
2) Remove this assertion: http://mxr.mozilla.org/mozilla-central/source/layout/base/FrameLayerBuilder.cpp#2099

Matt can you weight in on the implications here.

Comment 2

[Benoit Girard (:BenWa)]

We discussed this in person. We're moving the area from the layer visible region to the frame metrics.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Use mViewport instead

The changes to layout are the same minus two hunks that are no longer needed. Modified the tests and hit testing code.

https://tbpl.mozilla.org/?tree=Try&rev=c0512cb7f643

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 772480 [details] [diff] [review]
Use mViewport instead

Review of attachment 772480 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +157,5 @@
>  
> +    const FrameMetrics& frame = aContainer->GetFrameMetrics();
> +    CSSRect viewport = frame.mViewport;
> +    CSSToLayerScale paintedScale = frame.mDevPixelsPerCSSPixel * frame.mResolution;
> +    LayerRect layerViewport = viewport * paintedScale;

You can do frame.mViewport * frame.LayerPixelsPerCSSPixel() here, it's a little simpler.

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +1483,5 @@
> +  if (aLayer.GetFrameMetrics().IsScrollable()) {
> +    const FrameMetrics& frame = aLayer.GetFrameMetrics();
> +    CSSRect viewport = frame.mViewport;
> +    CSSToLayerScale paintedScale = frame.mDevPixelsPerCSSPixel * frame.mResolution;
> +    LayerRect layerViewport = viewport * paintedScale;

Ditto here

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Use mViewport instead

Comment 6

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48d6452c9d10

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48d6452c9d10