Closed Bug 890353 Opened 7 years ago Closed 6 years ago

move get text for line boundary tests into separate file

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #771402 - Flags: review?(trev.saunders)
Comment on attachment 771402 [details] [diff] [review]
patch

>+      testTextBeforeOffset(IDs, BOUNDARY_LINE_START,
>+                           [ [ 0, 15, "", 0, 0 ] ]);
>+      testTextBeforeOffset(IDs, BOUNDARY_LINE_END,
>+                           [ [ 0, 5, "", 0, 0 ] ]);

why 5 not 15? or some higher value to test the case of garbage arg?

>+      testTextAtOffset(IDs, BOUNDARY_LINE_START,
>+                       [ [ 0, 15, "hello my friend", 0, 15 ] ]);
>+      testTextAtOffset(IDs, BOUNDARY_LINE_END,
>+                       [ [ 0, 5, "hello my friend", 0, 15 ] ]);

same

> 
>-      ////////////////////////////////////////////////////////////////////////
>-      // getTextAtOffset
>+      testTextAfterOffset(IDs, BOUNDARY_LINE_START,
>+                          [ [ 0, 15, "", 15, 15 ] ]);
>+      testTextAfterOffset(IDs, BOUNDARY_LINE_END,
>+                          [ [ 0, 5, "", 15, 15 ] ]);

same

r=me with those explained
Attachment #771402 - Flags: review?(trev.saunders) → review+
copy/paste issue I think
Assignee: nobody → surkov.alexander
https://hg.mozilla.org/mozilla-central/rev/d4afe4997be6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.