Closed
Bug 890353
Opened 12 years ago
Closed 12 years ago
move get text for line boundary tests into separate file
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
14.00 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #771402 -
Flags: review?(trev.saunders)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 771402 [details] [diff] [review]
patch
>+ testTextBeforeOffset(IDs, BOUNDARY_LINE_START,
>+ [ [ 0, 15, "", 0, 0 ] ]);
>+ testTextBeforeOffset(IDs, BOUNDARY_LINE_END,
>+ [ [ 0, 5, "", 0, 0 ] ]);
why 5 not 15? or some higher value to test the case of garbage arg?
>+ testTextAtOffset(IDs, BOUNDARY_LINE_START,
>+ [ [ 0, 15, "hello my friend", 0, 15 ] ]);
>+ testTextAtOffset(IDs, BOUNDARY_LINE_END,
>+ [ [ 0, 5, "hello my friend", 0, 15 ] ]);
same
>
>- ////////////////////////////////////////////////////////////////////////
>- // getTextAtOffset
>+ testTextAfterOffset(IDs, BOUNDARY_LINE_START,
>+ [ [ 0, 15, "", 15, 15 ] ]);
>+ testTextAfterOffset(IDs, BOUNDARY_LINE_END,
>+ [ [ 0, 5, "", 15, 15 ] ]);
same
r=me with those explained
Attachment #771402 -
Flags: review?(trev.saunders) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
copy/paste issue I think
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → surkov.alexander
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•