890353 - move get text for line boundary tests into separate file

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 771402 [details] [diff] [review]
patch

>+      testTextBeforeOffset(IDs, BOUNDARY_LINE_START,
>+                           [ [ 0, 15, "", 0, 0 ] ]);
>+      testTextBeforeOffset(IDs, BOUNDARY_LINE_END,
>+                           [ [ 0, 5, "", 0, 0 ] ]);

why 5 not 15? or some higher value to test the case of garbage arg?

>+      testTextAtOffset(IDs, BOUNDARY_LINE_START,
>+                       [ [ 0, 15, "hello my friend", 0, 15 ] ]);
>+      testTextAtOffset(IDs, BOUNDARY_LINE_END,
>+                       [ [ 0, 5, "hello my friend", 0, 15 ] ]);

same

> 
>-      ////////////////////////////////////////////////////////////////////////
>-      // getTextAtOffset
>+      testTextAfterOffset(IDs, BOUNDARY_LINE_START,
>+                          [ [ 0, 15, "", 15, 15 ] ]);
>+      testTextAfterOffset(IDs, BOUNDARY_LINE_END,
>+                          [ [ 0, 5, "", 15, 15 ] ]);

same

r=me with those explained

Comment 2

[alexander :surkov (:asurkov)]

copy/paste issue I think

Comment 3

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d4afe4997be6

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4afe4997be6