Closed
Bug 890429
Opened 10 years ago
Closed 3 years ago
SeaMonkey master failing to upload log files
Categories
(SeaMonkey :: Release Engineering, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Callek, Unassigned)
Details
Attachments
(1 file)
3.69 KB,
patch
|
dustin
:
review+
|
Details | Diff | Splinter Review |
So, postrun.cfg hardcodes ffxbld, this is bad and seamonkey needs a different postrun This file is managed by puppet so we need some magic here. I can think of a few possible ways this patch's needs would make sense here. This is the one I chose but if you prefer a different option feel free to tell me and we can chat.
Attachment #771527 -
Flags: review?(dustin)
Comment 1•10 years ago
|
||
Comment on attachment 771527 [details] [diff] [review] [puppet] postrun.cfg by $org Review of attachment 771527 [details] [diff] [review]: ----------------------------------------------------------------- This is fine, but I'd rather use $::config::org in the path to the template, e.g., template("${module_name}/${::config::org}/postrun.cfg"). Then it will fail for any org that hasn't set up a postrun.cfg.
Attachment #771527 -
Flags: review?(dustin) → review+
Reporter | ||
Comment 2•10 years ago
|
||
per :dustin this could land without making the adjustment, but leaving open in prep for a better fix. https://hg.mozilla.org/build/puppet/rev/d0d9e3149ccf
![]() |
||
Comment 3•3 years ago
|
||
This is no longer relevant to SeaMonkey. Unassigning and closing bug.
Assignee: bugspam.Callek → administration
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•