890429 - SeaMonkey master failing to upload log files

Status: NEW

(SeaMonkey :: Release Engineering, defect)

Description

[Justin Wood (:Callek)]

Attachment: [puppet] postrun.cfg by $org

So, postrun.cfg hardcodes ffxbld, this is bad and seamonkey needs a different postrun

This file is managed by puppet so we need some magic here.

I can think of a few possible ways this patch's needs would make sense here. This is the one I chose but if you prefer a different option feel free to tell me and we can chat.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 771527 [details] [diff] [review]
[puppet] postrun.cfg by $org

Review of attachment 771527 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but I'd rather use $::config::org in the path to the template, e.g., template("${module_name}/${::config::org}/postrun.cfg").  Then it will fail for any org that hasn't set up a postrun.cfg.

Comment 2

[Justin Wood (:Callek)]

per :dustin this could land without making the adjustment, but leaving open in prep for a better fix.

https://hg.mozilla.org/build/puppet/rev/d0d9e3149ccf