Closed
Bug 890448
Opened 11 years ago
Closed 11 years ago
[Dialer] When receiving second call that has withheld number, shows contact information (not withheld number token)
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)
Tracking
(blocking-b2g:-)
RESOLVED
FIXED
blocking-b2g | - |
People
(Reporter: leo.bugzilla.gaia, Assigned: arthurcc)
References
Details
(Whiteboard: [TD-57637], [u=commsapps-user c=dialer p=0])
Attachments
(2 files)
1. Title : When receiving second call that has withheld number, shows contact information (not withheld number token) 2. Precondition : save other contacts 3. Tester's Action : Receive second call that has withheld number 4. Detailed Symptom : Show wrong contact information 5. Expected : Show 'withheld number' token 6. Reproducibility: Y 1) Frequency Rate : 100% 7. Gaia Master/v1-train : Reproduce 8. Gaia Revision : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3 9. Gecko Revision : be276cf55ce160bca09f36d9ca679a2ae20ea7cc 10. Personal email id : promise09th@gmail.com
blocking-b2g: leo? → leo+
Priority: -- → P2
Whiteboard: [TD-57637]
Target Milestone: --- → 1.1 QE4 (15jul)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → arthur.chen
Assignee | ||
Comment 2•11 years ago
|
||
Leo, I cannot reproduce this bug. Could you help check the number of the second phone is hidden? If the number is hidden from the carrier side successfully, there is no way for firefox os to get the number and query corresponding contact info.
Flags: needinfo?(leo.bugzilla.gaia)
Updated•11 years ago
|
Whiteboard: [TD-57637] → [TD-57637], [u=commsapps-user c=dialer p=0]
I reproduce below revision too. Gaia : 0d5a9a7577f16b6a72a982148c6f509ee1714ea2 Gecko : 499c1f8ea7ad0cdaa7086214278e2944b8a2ea33 I think below codes have problem. https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/oncall.js#L429 Even if number is withheld number, dialer check contacts. In contacts.js, dialer send "withheld number" token to gecko part.
Flags: needinfo?(leo.bugzilla.gaia)
Assignee | ||
Comment 4•11 years ago
|
||
You are right, the code is a little bit confusing. However, on my device it did not find any valid contact and returned null. I will check it using the gecko build you specified.
Assignee | ||
Comment 5•11 years ago
|
||
Leo, could you specify the build ID (not the commit hash) you used? Thanks.
Flags: needinfo?(leo.bugzilla.gaia)
Build Identifier : 20130709110051 I have a mistake. I add some informations. v1-train : doesn't show any string master : show other contacts Because "simple_phone_matcher.js" is different, v1-train doesn't show any string and master show other contacts. In "simple_phone_matcher.js", bestMatch function of v1-train is different from master's In v1-train, ============================= bestMatch: function spm_bestMatchIndex(variants, matches) { var bestMatchIndex = null; var bestLocalIndex = null; ============================= and master, ============================= bestMatch: function spm_bestMatchIndex(variants, matches) { var bestMatchIndex = 0; var bestLocalIndex = 0; ============================= In leo version, Bug 877302 is applied because we solve TD issue. I'm sorry to confuse you.
Flags: needinfo?(leo.bugzilla.gaia)
Updated•11 years ago
|
Flags: in-moztrap+
When receiving withheld-number, doesn't check contacts
Attachment #773763 -
Flags: review?(etienne)
Comment 8•11 years ago
|
||
Arthur, Etienne, This bug here is basically a side effect of Bug 877302, so once that has (I think it has already) landed on v1-train, this one here would appear.
Comment 9•11 years ago
|
||
Making this block bug 877302 as partner suggests that once 877302 lands, this bug here would appear. Also marking this leo? as without 877302 this here is invalid for v1-train.
Attachment #773763 -
Attachment is obsolete: true
Attachment #773763 -
Flags: review?(etienne)
Attachment #773763 -
Flags: review?(etienne)
Attachment #773763 -
Attachment is obsolete: false
Comment 10•11 years ago
|
||
Comment on attachment 773763 [details]
Pull Request URL 10909
Thank you for the fix!
Attachment #773763 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 11•11 years ago
|
||
Leo, thanks for the effort! master: https://github.com/mozilla-b2g/gaia/commit/5a0e6f6b7aa43daee340b7f3097a53acac11cc19
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
blocking-b2g: leo? → leo+
Updated•11 years ago
|
blocking-b2g: leo+ → -
You need to log in
before you can comment on or make changes to this bug.
Description
•