890529 - Change - Improve variables and localization comment for crashprompt.messagebody

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Francesco Lodolo [:flod]]

Current string landed in bug 886794

# LOCALIZATION NOTE: '%S' is short brand name
crashprompt.messagebody=We are sorry, %S just recovered from a crash. Sending crash reports will help %S make %S more stable and secure. You can always change your preference in Settings/Options.

One of those %S is Mozilla, not Firefox. Also, using ordered arguments clear any possible confusion.

# LOCALIZATION NOTE: %1$S is short brand name, %2$S is vendor name.
crashprompt.messagebody=We are sorry, %1$S just recovered from a crash. Sending crash reports will help %2$S make %1$S more stable and secure. You can always change your preference in Settings/Options.

At this point I guess the code could be adapted passing only two variables instead of three.

Comment 1

[Jim Mathies [:jimm] (OOTO until Oct 7th)]

Attachment: fix

easy fix.

Comment 2

[Francesco Lodolo [:flod]]

Given discussions in other bugs (e.g. bug 883951 comment 38), I would also change the key name here and use the more common localization note format with the key name.

# LOCALIZATION NOTE (crashprompt.messagebody):

Comment 3

[Allison Naaktgeboren :ally]

Comment on attachment 779177 [details] [diff] [review]
fix

Review of attachment 779177 [details] [diff] [review]:
-----------------------------------------------------------------

add :flod's followup comment in comment 2 and I think you're good to go

Comment 4

[Jim Mathies [:jimm] (OOTO until Oct 7th)]

Attachment: export

Comment 5

[Jim Mathies [:jimm] (OOTO until Oct 7th)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e17e35300225

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e17e35300225