Closed
Bug 890529
Opened 10 years ago
Closed 10 years ago
Change - Improve variables and localization comment for crashprompt.messagebody
Categories
(Firefox for Metro Graveyard :: Browser, defect, P2)
Firefox for Metro Graveyard
Browser
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: jimm)
References
()
Details
(Whiteboard: feature=change c=feedback u=metro_firefox_user p=1)
Attachments
(1 file, 1 obsolete file)
2.02 KB,
patch
|
Details | Diff | Splinter Review |
Current string landed in bug 886794 # LOCALIZATION NOTE: '%S' is short brand name crashprompt.messagebody=We are sorry, %S just recovered from a crash. Sending crash reports will help %S make %S more stable and secure. You can always change your preference in Settings/Options. One of those %S is Mozilla, not Firefox. Also, using ordered arguments clear any possible confusion. # LOCALIZATION NOTE: %1$S is short brand name, %2$S is vendor name. crashprompt.messagebody=We are sorry, %1$S just recovered from a crash. Sending crash reports will help %2$S make %1$S more stable and secure. You can always change your preference in Settings/Options. At this point I guess the code could be adapted passing only two variables instead of three.
Updated•10 years ago
|
Assignee: nobody → jmathies
Blocks: 831972, metrov1it11
Priority: -- → P2
QA Contact: jbecerra
Summary: Improve variables and localization comment for crashprompt.messagebody → Change - Improve variables and localization comment for crashprompt.messagebody
Whiteboard: feature=change c=feedback u=metro_firefox_user p=1
Updated•10 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•10 years ago
|
||
Given discussions in other bugs (e.g. bug 883951 comment 38), I would also change the key name here and use the more common localization note format with the key name. # LOCALIZATION NOTE (crashprompt.messagebody):
Comment 3•10 years ago
|
||
Comment on attachment 779177 [details] [diff] [review] fix Review of attachment 779177 [details] [diff] [review]: ----------------------------------------------------------------- add :flod's followup comment in comment 2 and I think you're good to go
Attachment #779177 -
Flags: review?(ally) → review+
![]() |
Assignee | |
Comment 4•10 years ago
|
||
![]() |
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e17e35300225
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #779177 -
Attachment is obsolete: true
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e17e35300225
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•