890538 - [meta] Update API handling & response codes for the Login server

Status: RESOLVED INVALID

(Webmaker Graveyard :: Login, defect)

Description

[Matthew Schranz [:mjschranz]]

This stems from the following comment https://github.com/mozilla/node-webmaker-loginapi/pull/20#discussion_r5046276.

Right now the login server returns an actual error when it doesn't find a user yet it's status code is 404. This lead to a problem with account creation in recent SSO changes.

We should sort this out to make it nice and clear for consuming applications.

Comment 1

[Kieran Sedgwick (:sedge)]

This bug now covers four patches:

1) Updating API design documentation
2) Updating the server logic, response codes and unit tests
3) Updating the node-webmaker-loginapi client library
4) Updating client-side calls to the login server

Comment 2

[Kieran Sedgwick (:sedge)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/140

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 786385 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/140

I left some comments in the pull request for you to ponder upon.

Comment 4

[David Humphrey (:humph)]

Sedge, do you want to fix Cade's stuff and then flag me again?

Comment 5

[Kieran Sedgwick (:sedge)]

Comment on attachment 786385 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/140

Ready for ya now!