890599 - Lightning 2.5b1: Linux 32/64 bit universal builds broken due to incorrect libical.manifest

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

From <http://forums.mozillazine.org/viewtopic.php?p=12954197#p12954197>

> I just updated my thunder to 23.0 and lightning to 2.5 and lightning died.
> just updated the lines in libical.manifest about the binary component to look like the ones in components.manifest
> On linux it would look like this

> --- libical.manifest.bak        2013-07-02 16:35:23.000000000 -0300
> +++ libical.manifest    2013-07-04 17:51:35.423682575 -0300
> @@ -1,2 +1,3 @@
> -binary-component libcalbasecomps.so
> +binary-component Linux_x86-gcc3/libcalbasecomps.so abi=Linux_x86-gcc3
> +binary-component Linux_x86_64-gcc3/libcalbasecomps.so abi=Linux_x86_64-gcc3
>  interfaces caldatetime_libical.xpt

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Huh? A problem with the recent patch or was it maybe not taken into account? Looks like I will have to do a b2 for this.

Comment 2

[Stefan Sitter [:ssitter]]

Maybe there is a separate build script that creates the unified beta or release builds? 

The Linux nightly builds are not unified but a separate 32-bit build and 64-bit build is created and uploaded to ftp.mozilla.org.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Oh right, sorry. Indeed there is a manual script that does this, looks like I either forgot to call it on the final xpi or its not updated to the libical manifest. Should be easy to do a b2 in that case.

Comment 4

[Stefan Sitter [:ssitter]]

Is the manual build script located in the calendar repository? Is yes: where? If no: why not?

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: fix_linux_xpi.sh

(In reply to Stefan Sitter from comment #4)
> Is the manual build script located in the calendar repository? Is yes:
> where? If no: why not?

Its not in the calendar repository, as it was rather a quick hack to make it work. The ideal soultion would be to turn this into a buildbot step which the tb infra could trigger once both linux builds are done.

I've attached the script for convenience with slight modifications which *should* make it work for libical.manifest.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Lightning 2.5b2 linux

Do you have a linux box at hand to test this? Here is a fixed version, repackaged as 2.5b2.

Comment 7

[John C. Vernaleo]

The attached xpi seems to work fine (with admittedly light testing) on Ubuntu 12.04 64bit with a recent tbird daily: 24.0a1 (2013-06-18).

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 772003 [details]
Lightning 2.5b2 linux

f=jcv, thanks for testing. Will upload these to amo now.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Uploaded to amo now, marking as FIXED

https://addons.mozilla.org/en-US/developers/addon/lightning/versions/1472540

Comment 10

[Stefan Sitter [:ssitter]]

(In reply to John C. Vernaleo from comment #7)

This should not be possible. Lightning 2.5 Beta requires Thunderbird 23 Beta and doesn't support Thunderbird 24 or Thunderbird 25.

Comment 11

[John C. Vernaleo]

(In reply to Stefan Sitter from comment #10)
> (In reply to John C. Vernaleo from comment #7)
> 
> This should not be possible. Lightning 2.5 Beta requires Thunderbird 23 Beta
> and doesn't support Thunderbird 24 or Thunderbird 25.

I just tried it again and it definitely lets me install from file and then after I restart tbird, I can open the calendar tab.  I didn't try anything beyond that since I don't currenly have any calendars in my test profile (so it entirely possible that things don't work completely).

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hmm I just read the "works" bit, missed the version info. Possible that the builds are binary compatible by coincidence. John, it would be nice if you could test again with the beta build from the beta channel at http://www.mozilla.org/en-US/thunderbird/channel/ ?

Comment 13

[John C. Vernaleo]

I tried the attached xpi (2.5b2 linux) on my 32bit linux machine (ubuntu 12.04) using thunderbird from the beta channel (23.0) and it works.  I tried moving around in the calendar, creating events, and a bunch of other little things and all seem good.

I cannot try on my 64bit box since the binary in the beta channel does not work on 64bit (and I did not try to fool around with any of the 32bit compat libs).

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks, that should be fine. I'll consider this fixed until someone complains that its not working.