Find bar background shouldn't be white

VERIFIED FIXED in Firefox 25

Status

()

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: hobophobe)

Tracking

({regression})

Trunk
Firefox 25
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
As of bug 537013, the find bar background is white. It should have a toolbar color instead.

Adam, can you take this?
(Assignee)

Comment 1

5 years ago
Created attachment 771799 [details] [diff] [review]
Add background-color for Linux findbar

I haven't tried on Windows/OSX, but their toolkit styles (findBar.css) have explicit background colors, so guessing this only affects Linux?  

The old parent of the findbar, #browser-bottombox has background-color of -moz-dialog, and findbar has transparent background, but the new ancestry for findbars means the color comes from tabbrowser (white background via a style attribute, but didn't look at why).

Change is to add a background-color for |.browserContainer > findbar|, in the browser theme in case other products have their own style.
Assignee: nobody → unusualtears
Status: NEW → ASSIGNED
Attachment #771799 - Flags: review?(dao)
(Reporter)

Comment 2

5 years ago
I've seen this on Windows. I don't see a background color being set there either.
(Reporter)

Comment 3

5 years ago
Also, could you fix the lightweight theme handling? Neither the lwt's text color nor the text-shadow should be inherited as the lwt's background isn't visible either.
(Assignee)

Comment 4

5 years ago
Created attachment 771889 [details] [diff] [review]
Override the lwtheme values for color, text-shadow

This should be close, but I don't have Windows except for WINE or OS X except for minor testing on someone else's box.  If this isn't close, it may be better for someone with full access to those platforms to take this.  

> --- a/browser/themes/osx/browser.css
> +++ b/browser/themes/osx/browser.css
> [...]
> +/* ----- CONTENT ----- */
> +
> +.browserContainer > findbar {
> +  background: @scopeBarBackground@;
> +  border-top: @scopeBarSeparatorBorder@;
> +  color: -moz-DialogText;
> +  text-shadow: none;
> +}

This selector competes with a toolkit style selector for |findbar:-moz-lwtheme|.  It should be the same specificity and is applied after, so it should prevail.

The |findbar:-moz-lwtheme| rule also includes |-moz-appearance: none|, but not sure what that's overriding (maybe |-moz-appearance: toolbar|?).  Something more may be needed to account for that.

The other platforms don't have a |findbar:-moz-lwtheme| rule to compete with.
Attachment #771799 - Attachment is obsolete: true
Attachment #771799 - Flags: review?(dao)
Attachment #771889 - Flags: review?(dao)
(Reporter)

Updated

5 years ago
Attachment #771889 - Flags: review?(dao) → review+
(Reporter)

Comment 5

5 years ago
(In reply to Adam [:hobophobe] from comment #4)
> The |findbar:-moz-lwtheme| rule also includes |-moz-appearance: none|, but
> not sure what that's overriding (maybe |-moz-appearance: toolbar|?). 
> Something more may be needed to account for that.

I don't think it's overriding anything. Seems like a no-op.
Keywords: checkin-needed
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1639af60732e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
While testing for the pre-beta sign-off of the Find Bar Redesign feature, I tried to verify this bug with the latest Aurora (build ID: 20130902004002), and this works as expected on Win 8 32bit, Ubuntu 12.10 32bit and Windows 7 64bit.
Status: RESOLVED → VERIFIED
QA Contact: manuela.muntean
You need to log in before you can comment on or make changes to this bug.