890600 - Find bar background shouldn't be white

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

As of bug 537013, the find bar background is white. It should have a toolbar color instead.

Adam, can you take this?

Comment 1

[Adam]

Attachment: Add background-color for Linux findbar

I haven't tried on Windows/OSX, but their toolkit styles (findBar.css) have explicit background colors, so guessing this only affects Linux?  

The old parent of the findbar, #browser-bottombox has background-color of -moz-dialog, and findbar has transparent background, but the new ancestry for findbars means the color comes from tabbrowser (white background via a style attribute, but didn't look at why).

Change is to add a background-color for |.browserContainer > findbar|, in the browser theme in case other products have their own style.

Comment 2

[Dão Gottwald [:dao]]

I've seen this on Windows. I don't see a background color being set there either.

Comment 3

[Dão Gottwald [:dao]]

Also, could you fix the lightweight theme handling? Neither the lwt's text color nor the text-shadow should be inherited as the lwt's background isn't visible either.

Comment 4

[Adam]

Attachment: Override the lwtheme values for color, text-shadow

This should be close, but I don't have Windows except for WINE or OS X except for minor testing on someone else's box.  If this isn't close, it may be better for someone with full access to those platforms to take this.  

> --- a/browser/themes/osx/browser.css
> +++ b/browser/themes/osx/browser.css
> [...]
> +/* ----- CONTENT ----- */
> +
> +.browserContainer > findbar {
> +  background: @scopeBarBackground@;
> +  border-top: @scopeBarSeparatorBorder@;
> +  color: -moz-DialogText;
> +  text-shadow: none;
> +}

This selector competes with a toolkit style selector for |findbar:-moz-lwtheme|.  It should be the same specificity and is applied after, so it should prevail.

The |findbar:-moz-lwtheme| rule also includes |-moz-appearance: none|, but not sure what that's overriding (maybe |-moz-appearance: toolbar|?).  Something more may be needed to account for that.

The other platforms don't have a |findbar:-moz-lwtheme| rule to compete with.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Adam [:hobophobe] from comment #4)
> The |findbar:-moz-lwtheme| rule also includes |-moz-appearance: none|, but
> not sure what that's overriding (maybe |-moz-appearance: toolbar|?). 
> Something more may be needed to account for that.

I don't think it's overriding anything. Seems like a no-op.

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/mozilla-central/rev/1639af60732e

Comment 8

[Manuela Muntean [Away]]

While testing for the pre-beta sign-off of the Find Bar Redesign feature, I tried to verify this bug with the latest Aurora (build ID: 20130902004002), and this works as expected on Win 8 32bit, Ubuntu 12.10 32bit and Windows 7 64bit.