Closed Bug 890620 Opened 11 years ago Closed 11 years ago

Password dialog doesn't mask password

Categories

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Product:
Firefox for Android Graveyard
Component:
Keyboards and IME
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox22 unaffected, firefox23 unaffected, firefox24 verified, firefox25 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox22 --- unaffected
firefox23 --- unaffected
firefox24 --- verified
firefox25 --- verified

People

(Reporter: kats, Assigned: jchen)

References

Details

(Keywords: privacy, regression, reproducible)

Attachments

(1 file)

Specify InputType.TYPE_CLASS_TEXT for password prompt inputs (v1)
1.22 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
STR:
1. Go to e.g. intranet.mozilla.org (or any page with HTTP auth)
2. In the password dialog that pops up, enter something in the password

Expected:
password should be masked

Actual:
password is not masked
tracking-fennec: --- → ?
status-firefox23: --- → ?
status-firefox24: --- → ?
status-firefox25: --- → affected
Component: General → Keyboards and IME
Flags: needinfo?(nchen)
Keywords: privacy, regression, regressionwindow-wanted, reproducible
The regression window is:

1.mozilla-central
good build: 31.05.2013 
bad build: 01.06.2013 
-pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3c6f2394995d&tochange=b7344a8ee6f2

2.inbound
good build:1369781723
bad build: 1370057753
-pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4187c565aec5&tochange=439b8967c5ae
Huge change-log in the above range; I see the refactoring from bug 867517 in there
Based on the m-c range I would say bug 862377. Something must have been lost in the refactoring, a quick look shows that the new code clobbers the InputType.TYPE_CLASS_TEXT type flag on the password input, which might be the cause.
Blocks: 862377
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Based on the m-c range I would say bug 862377. Something must have been lost
> in the refactoring, a quick look shows that the new code clobbers the
> InputType.TYPE_CLASS_TEXT type flag on the password input, which might be
> the cause.

Yeah that fixes it.
Attachment #772242 - Flags: review?(wjohnston)
Flags: needinfo?(nchen)
Attachment #772242 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/7902d35bb109
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Status: RESOLVED → VERIFIED
status-firefox25: fixed → verified
Comment on attachment 772242 [details] [diff] [review]
Specify InputType.TYPE_CLASS_TEXT for password prompt inputs (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 862377

User impact if declined: Login passwords are not masked

Testing completed (on m-c, etc.): Locally, m-c

Risk to taking this patch (and alternatives if risky): No risk; patch fixes a simple regression

String or IDL/UUID changes made by this patch: None
Attachment #772242 - Flags: approval-mozilla-aurora?
Attachment #772242 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
Build: Firefox for Android 24.0a2( 2013-07-17)
Device: Acer Iconia
OS: Android 3.2
status-firefox24: fixed → verified
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: