Closed
Bug 890655
Opened 11 years ago
Closed 11 years ago
underscore in username causes publishing to fail
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Webmaker Graveyard
MakeAPI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: mjschranz)
Details
Attachments
(1 file)
A user created a username with a underscore in front, which caused popcorn maker to not save the project. Removing the _ allowed the project to save properly again.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → schranz.m
|
|
Assignee | |
Comment 1•11 years ago
|
||
As diagnosed, the problem is actually in the MakeAPI. Right now the validator we use on URLs is actually incorrectly not allowing URLs that have that underscore in them.
Status: NEW → ASSIGNED
Component: Popcorn Maker → MakeAPI
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #773266 -
Flags: review?(chris)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 773266 [details] [review] https://github.com/mozilla/MakeAPI/pull/108 R+ With a comment change.
Attachment #773266 -
Flags: review?(chris) → review+
|
||
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/MakeAPI https://github.com/mozilla/MakeAPI/commit/dc92315ebf19e3e097b3ed3d05b2bb0b9d0b330b Fix Bug 890655 - URL validator needs to accept underscores in hostname
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•