890697 - [Accessibility] Unlabeled button on the web apps screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Marco Zehe (:MarcoZ)]

STR:
1. With TalkBack enabled, go to Menu -> Tools -> Apps.
2. Regardless of whether you have apps installed or not, start swiping to the right through the controls.

Result: There is an unlabeled button at the top of the page. This button is present either with or without apps installed. TalkBack will just say "button", but not what the button actually does. Probably an image button without alternative text (since this seems to be HTML, not native Android).

Comment 1

[Aaron Train [:aaronmt]]

I tried this out, it's highlighting the Marketplace shortcut icon on the top right. The markup for it is:

<div id="header-button" role="button" pref="app.marketplaceURL" onclick="openLink(this);"/>

Comment 2

[Marco Zehe (:MarcoZ)]

Thanks Aaron! Then, the only thing this needs is an additional attribute: aria-label with a value of a localizable string saying something lik "Create Mozilla Market Place shortcut on your home screen" or something similarly sensible. ;) Localizable, because this is what gets spoken when present.

Comment 3

[Max Li [:maxli]]

Attachment: Patch

Comment 4

[Marco Zehe (:MarcoZ)]

This looks correct. The only interesting question is if the shortcut already exists, does the icon change to something that allows the user to remove the shortcut again? If so, the JS or whatever is used must be modified to also update the aria-label to something appropriate.

(cool that we don't have to add a new string, but can reuse an existing one for the label! :)

Comment 5

[Aaron Train [:aaronmt]]

The button is just a link (non-removable) to the Marketplace, that's all it is.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 772041 [details] [diff] [review]
Patch

Good enough for now. We might want to consider an explicit string, but I think the add-ons manager code will change a lot in the next few months.

Comment 7

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdfcd72cae5a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fdfcd72cae5a

Comment 9

[Marco Zehe (:MarcoZ)]

Verified fixed in Firefox 25.0a1 (2013-07-11).