890706 - [sms] contact search should look up in the company field as well

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

bug 880644 comment 30 suggests that we should look up the company in the contact auto suggestion list.

However, the MMS spec (page 7) says that we should correlate only the first or last name. 

Therefore, needinfo Ayman to shed some light before doing any work.

Comment 1

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> bug 880644 comment 30 suggests that we should look up the company in the
> contact auto suggestion list.
> 
> However, the MMS spec (page 7) says that we should correlate only the first
> or last name. 
> 
> Therefore, needinfo Ayman to shed some light before doing any work.

i dont see any problem with us searching 'company field' as well. From a UX PoV I would see the results laid out as follows (where the final entry is picking up the 'Mark' in the company field):

To: Mark|
----------------------
Mark Alfenito
mobile, 420420420
----------------------
Howard Marks
mobile, [phone]
----------------------
John Taylor
Marks & Spencers
----------------------

I will update the spec. NeedInfo me if you need any further input to move forwards

Comment 2

[Julien Wajsberg [:julienw]]

Ayman, I'd say it's not blocking leo though. Do you agree ?

Comment 3

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Ayman, I'd say it's not blocking leo though. Do you agree ?

no, form my PoV its a nice to have... but we should aim to get it in as soon as is convenient.

Comment 4

[Rick Waldron [:rwaldron]]

Assuming you actually mean the "org" field, since there is no "company" field ;)

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: Github Pull Request https://github.com/mozilla-b2g/gaia/pull/10845

Comment 6

[bov]

(In reply to Rick Waldron from comment #4)
> Assuming you actually mean the "org" field, since there is no "company"
> field ;)

I suppose, "Org" field as var field in the code, but "Company" field in the device for the final user.

Comment 7

[Rick Waldron [:rwaldron]]

(In reply to bov from comment #6)
> (In reply to Rick Waldron from comment #4)
> > Assuming you actually mean the "org" field, since there is no "company"
> > field ;)
> 
> I suppose, "Org" field as var field in the code, but "Company" field in the
> device for the final user.

Of course :)

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 772177 [details] [review]
Github Pull Request https://github.com/mozilla-b2g/gaia/pull/10845

The patch breaks the search, because "org" is not a valid search key in the contact API right now.

Related (debug) logs is :

I/Gecko   ( 1770): -*- ContactManager: find! {"sortBy":"undefined","sortOrder":"undefined","filterValue":"ale","filterOp":"contains","filterBy":["tel","givenName","familyName","org"],"filterLimit":0}
I/Gecko   ( 1770): -*- ContactManager: askPermission for contacts
I/Gecko   (  108): -*- Fallback ContactService component: Fallback DOMContactManager::receiveMessage Contacts:Find
I/Gecko   (  108): -*- ContactDB component: ContactDB:find val:ale by: tel,givenName,familyName,org op: contains
I/Gecko   (  108): -*- ContactDB component: _findWithIndex: ale contains tel,givenName,familyName,org 
I/Gecko   (  108): -*- ContactDB component: key: tel
I/Gecko   (  108): -*- ContactDB component: key: givenName
I/Gecko   (  108): -*- ContactDB component: key: familyName
I/Gecko   (  108): -*- ContactDB component: key: org
I/Gecko   (  108): -*- ContactDB component: Key not valid!org, {"0":"category","1":"email","2":"emailLowerCase","3":"familyName","4":"familyNameLowerCase","5":"givenName","6":"givenNameLowerCase","7":"tel","8":"telLowerCase","9":"telMatch"}
I/Gecko   ( 1770): -*- ContactManager: receiveMessage: Contacts:Find:Return:KO

Rick, would you please file a bug on Core/Device Interfaces, blocking this one ?

Also, see Comment 1 about how this should look like in the suggestion list.

Also, this is not leo+, so we should focus on those bugs instead first, because if we merge non-leo+ bugs this will likely produce conflicts... When we'll have less leo+ bugs (hopefully end of this month) we'll be able to work on more non-leo+ bugs.

Last but not least, please do not ask for review without testing on your device ;)

Removing the review for now, because we're not ready for this.

Comment 9

[Rick Waldron [:rwaldron]]

Oh my...


https://bugzilla.mozilla.org/show_bug.cgi?id=891385

Comment 10

[Julien Wajsberg [:julienw]]

This should be easy to do for a contributor but first bug 891385 needs to be fixed. That bug is not difficult either (mostly easy IndexedDB stuff) but it's in Gecko so it's a little more involved.

Comment 11

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 12

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(