890751 - Defect - Find bar should not display when the start screen is loaded

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

If a user selects "Find in Page" under the awesome screen and then loads a website, the "Find" bar will quickly appear and then disappear while the website is being loaded.

1) Open Firefox Metro
2) Select the "Settings" button under the "Navigation App Bar"
3) Select "Find in Page" (nothing will occur)
4) Select a website from "Top Sites", "Bookmarks", or "Recent History" (You will notice that the "Find" bar will quickly appear and then disappear)

Current Behavior:

- If you select the "Find in Page" on the awesome screen and then open a website, the "Find" bar will quickly appear then disappear

Expected Behavior:

- When the user opens a website after attempting to use "Find in Page" on the awesome screen, the "Find" bar shouldn't appear

Comment 1

[Jim Mathies [:jimm]]

Related STR:

1) from start page, hit ctrl-f
2) open a top site

result: nav bar and find bar will briefly be seen then hide.

(The find bar is behind the nav bar)

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

one line fix.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 772572 [details] [diff] [review]
fix

Review of attachment 772572 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d16f5d0295ef

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130715 Firefox/25.0

Verified as fixed on latest nightly build using the steps from description.
When the user opens a website after attempting to use "Find in Page" on the awesome screen, the "Find" bar isn't shown.

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-15-03-02-03-mozilla-central/

- Went through the original test case in comment #0 without any issues
- The "Settings" menu has been removed from the awesome screen fixing the case in comment #0
- Went through the test case in comment #1 and everything worked without any issues
- Pressed "CTRL + F" several times and then opened several websites through "Top Sites", "Bookmarks" without issues
- Tried reproducing the issue through wikipedia (not the awesome screen) and the Find Bar was retracted when opening a new tab without issues
- Went through all of the above test cases in Filled View without any issues

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #20 with some issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-23-03-02-03-mozilla-central/

- Went through original test cases in comment #0 without any issues
- Went through Jims STR in comment #1 without any issues
- Went through the test cases that have been added in comment #6 without any issues
- Ensured that "Find in page" was removed from the "Settings" menu under the Navigation App Bar
- Ensured that pressing "CTRL + F" doesn't slide in the Find App Bar while the user is on about:start
- Ensured that pressing "CTRL + F" several times under about:start and then opening a new tab using Top Sites, Bookmarks and Recent History didn't slide in the Find App Bar
- Ensured that pressing "CTRL + F" several times under about:start and than creating a new tab using "CTRL + T" didn't slide in the Find App Bar

Issues found during testing:

- Found an issue when going through this defect. When you are in filled view, pressing "CTRL+F" and then opening links that are under the "Recent History" will produce a black app bar. Created Bug 953069.