890764 - Defect - Navigation App Bar not visible at times when loading websites

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P3)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: Navigation App Bar not visible while website loading

If a user taps on the white spaces on the awesome screen several times and then continues to open a website under one of the categories (Top Sites, Bookmarks, Recent History), the "Navigation App Bar" will not be visible while the website is being loaded.

- Attached a short video as this could be difficult to explain, notice that the second time around the navigation app bar isn't visible when the website is loading

Steps to reproduce the issue:

1) Open Firefox Metro
2) Select "About Us" under the bookmarks (notice that the Navigation App bar is visible while loading)
3) Once the website has been loaded, select the "New Tab" overlay
4) On the awesome screen, tap on the white spaces several times (2-3) and then select "About Us" again (notice that the Navigation App bar is not visible while the website is being loaded)

Current Behavior:

- Navigation App Bar not always appearing when loading websites

Expected Behavior:

- The Navigation App Bar should always be visible when loading new websites, it should be dismissed once the user either taps on the website

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-07-03-11-38-mozilla-central/

Comment 1

[Jim Mathies [:jimm]]

confirming - seems to have something to do with flipping back to the already opened tab.

Comment 2

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #1)
> confirming - seems to have something to do with flipping back to the already
> opened tab.

Actually, we open the same page ion the second tab, so we are loading the page again.

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

Basically a one line fix with some cleanup. We shouldn't call dismiss from peekTabs which also dismisses the nav bar. The nav bar should always be visible unless the user edge swipes.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 772584 [details] [diff] [review]
fix

Review of attachment 772584 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not actually able to reproduce this issue (even with patch not applied), but the patch seems fine so...

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e0f67d3e1dc

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified the fix with the latest Nightly build, using the steps from bug description: the Navigation App Bar remains visible when loading new websites or reloading pages previously opened in other tabs.

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-15-03-02-03-mozilla-central/

- Went through the original test cases in comment #0 without any issues
- Opened over several websites through "Top Sites", "Bookmarks" & "Recent History" without any issues
- Opened several tabs using the "+" through the Tab App Bar without any issues
- Went through all of the above test cases in Filled View without any issues