Closed Bug 890773 Opened 8 years ago Closed 8 years ago

Assertion failure: "expected mAllowZoom to be the same on both nsStyleFonts"

Categories

(Core :: SVG, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jruderman, Assigned: heycam)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

Attached image testcase
Assertion failure: mAllowZoom == aOther.mAllowZoom (expected mAllowZoom to be the same on both nsStyleFonts), at layout/style/nsStyleStruct.cpp:189

This assertion was added in bug 842181.

Does not crash in a non-debug build.
Attached file stack
Attached patch patchSplinter Review
When computing -x-text-zoom, I shouldn't be re-setting mAllowZoom when the rule data is null for that property, right?  I should just leave it at whatever the start struct has.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #778938 - Flags: review?(dbaron)
Comment on attachment 778938 [details] [diff] [review]
patch

Yes.  You should *never* touch the style data when the value is eCSSUnit_Null.  It means the property wasn't specified in the rules you've looked at -- which might be because it's not specified or might be because you copy-constructed the style struct off of a partially computed aStartStruct that did have it specified.
Attachment #778938 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/a06720bea809
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.