890773 - Assertion failure: "expected mAllowZoom to be the same on both nsStyleFonts"

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: mAllowZoom == aOther.mAllowZoom (expected mAllowZoom to be the same on both nsStyleFonts), at layout/style/nsStyleStruct.cpp:189

This assertion was added in bug 842181.

Does not crash in a non-debug build.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Cameron McCormack (:heycam)]

Attachment: patch

When computing -x-text-zoom, I shouldn't be re-setting mAllowZoom when the rule data is null for that property, right?  I should just leave it at whatever the start struct has.

Comment 3

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=dc4564af5f76

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 778938 [details] [diff] [review]
patch

Yes.  You should *never* touch the style data when the value is eCSSUnit_Null.  It means the property wasn't specified in the rules you've looked at -- which might be because it's not specified or might be because you copy-constructed the style struct off of a partially computed aStartStruct that did have it specified.

Comment 5

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a06720bea809

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a06720bea809