Created attachment 771919 [details] testcase Assertion failure: mAllowZoom == aOther.mAllowZoom (expected mAllowZoom to be the same on both nsStyleFonts), at layout/style/nsStyleStruct.cpp:189 This assertion was added in bug 842181. Does not crash in a non-debug build.
Created attachment 778938 [details] [diff] [review] patch When computing -x-text-zoom, I shouldn't be re-setting mAllowZoom when the rule data is null for that property, right? I should just leave it at whatever the start struct has.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #778938 - Flags: review?(dbaron)
Comment on attachment 778938 [details] [diff] [review] patch Yes. You should *never* touch the style data when the value is eCSSUnit_Null. It means the property wasn't specified in the rules you've looked at -- which might be because it's not specified or might be because you copy-constructed the style struct off of a partially computed aStartStruct that did have it specified.
Attachment #778938 - Flags: review?(dbaron) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.