890775 - "ASSERTION: Ancestors of nodes with frames to be constructed lazily should have frames" with <xbl:children>

Status: VERIFIED FIXED

(Core :: XBL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Ancestors of nodes with frames to be constructed lazily should have frames: '!noPrimaryFrame', file layout/base/nsCSSFrameConstructor.cpp, line 6249

Regression from bug 653881?

Security-sensitive because it might be related to bug 888728.

Comment 1

[Daniel Veditz [:dveditz]]

mrbkap: could this (and possibly 888728) be regressions from your bug 653881 landing?

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Both bugs are. I'll attach a patch here to fix it.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Reftest

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

With this patch, <xbl:children> elements that aren't part of a binding's <xbl:content> (generated into a bound document) no longer act as special elements and instead act more like normal elements. Note that they aren't rendered (I think because we don't render xbl elements)?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7d491276d9
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/09cb9725492e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c7d491276d9
https://hg.mozilla.org/mozilla-central/rev/09cb9725492e

Comment 7

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed assertion FF25, 2013-07-11.
Verified fixed FF25, 2013-10-01.