890813 - Memory Card import needs to support cancelling

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Cristian Rodriguez (:crdlc)]

User can cancel imports from SD card

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Cristian Rodriguez (:crdlc)]

I know that tests are failing but you can review the patch while I gonna fix them tomorrow, thanks

Comment 3

[Cristian Rodriguez (:crdlc)]

The tests have been fixed, good to merge :)

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 773231 [details]
Patch v1

There are several glitches when using the import tool, and the overlay will turn on and off very quickly, causing a big glitch when importing. It did that from the second time I tried to import.

I made a video of it, you can find it here: http://www.youtube.com/watch?v=LFjIxbuCvLs

Also, I don't know if it is related to the patch but the contacts list blinks when scrolling through contacts after importing.

Unfortunately I have to give it a r-, but it looks like it should be an easy fix.

Thanks Cristian!

Comment 5

[Cristian Rodriguez (:crdlc)]

Oh my god, you mobile phone is possessed ;). I've tested it on my Unagi with the current build of Gecko and works fine. I gonna test it with my Keon just in case. Thanks

Comment 6

[Cristian Rodriguez (:crdlc)]

I've just checked on Keon and it works fine as well. I don't have idea what is happening on Buri :(

Comment 7

[Cristian Rodriguez (:crdlc)]

All comments were addressed. Did you see some thing related to Buri and glitches? Thanks

Comment 8

[Cristian Rodriguez (:crdlc)]

Hi all, we have to take a decision in order to continue with the development. All comments/suggestions were implemented and it works fine on Unagi, Keon and Peak. According to Sergi the second import does weird glitches just on Buri. Maybe, we could fill a follow-up for dealing this case but we need to advance. What do you think Jose, Sergi?

Comment 9

[Jose Manuel Cantera]

Yes, let's land this and open an specific bug for the buri device

Comment 10

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Agreed. Merged at 057202ae7eed00b3c34208faf2b13b424c84691b

Comment 11

[isabelrios]

Verified with unagi master build (07/29)
Gecko-e08d007
Gaia-7d6c673
There is an option to cancel while importing contacts from Memory Card