890821 - Make nsIScrollableFrame::GetScrollPositionCSSPixels return CSSIntPoint

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 771963 [details] [diff] [review]
Patch v1

Review of attachment 771963 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGfxScrollFrame.h
@@ +524,5 @@
>    }
>    virtual void ScrollToCSSPixelsApproximate(const mozilla::CSSPoint& aScrollPosition) MOZ_OVERRIDE {
>      mInner.ScrollToCSSPixelsApproximate(aScrollPosition);
>    }
> +  virtual mozilla::CSSIntPoint GetScrollPositionCSSPixels() MOZ_OVERRIDE {

Can you typedef mozilla::CSSIntPoint CSSIntPoint in nsIFrame.h and nsGfxScrollFrameInner so we can minimize the amount of mozilla:: prefixing?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e98229cb45f3