Closed Bug 890847 Opened 11 years ago Closed 11 years ago

[SMS/MMS] The options shown in the dialog when tapping on a contact into ‘To’ field are the wrong way round

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: isabelrios, Assigned: gduan)

References

Details

(Whiteboard: MMS_TEF, [u=commsapps-user c=messaging p=0.5], [LeoVB+] )

Attachments

(2 files)

Remove contact dialog
92.03 KB, image/png
Details
https://github.com/mozilla-b2g/gaia/pull/10835
358 bytes, text/html
borjasalguero
: review+
Details
Attached image Remove contact dialog — 
This is a follow up bug of bug 880624

STR
1.Start creating a SMS or MMS.
2.Tap on ‘+’ to add one recipient from contacts
3.Once the contact is into ‘To’ field, tap on it
4.Check the dialog shown

EXPECTED
The buttons colour is ok but the remove button should be on the left side.

ACTUAL
The two buttons at the bottom are in the wrong place. 
See attached file.
Comment on attachment 772010 [details]
https://github.com/mozilla-b2g/gaia/pull/10835

put cancel button on the right side.
Attachment #772010 - Flags: review? → review?(schung)
Blocking on the assumption that you're reporting this based on system-wide spec criteria and consistency in the OS.
blocking-b2g: leo? → leo+
Flags: needinfo?(firefoxos-ux-bugzilla)
Ayman, can you verify and/or post a link to the system-wide expectation for modals (OK/Cancel).
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(aymanmaat)
Whiteboard: MMS_TEF → MMS_TEF, [u=commsapps-user c=messaging p=0]
Assignee: nobody → gduan
Test cases available in MozTrap #8025
Flags: in-moztrap+
George, I've sent you a PR with small tweaks. Could you take a look? Thanks!
Flags: needinfo?(gduan)
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Whiteboard: MMS_TEF, [u=commsapps-user c=messaging p=0] → MMS_TEF, [u=commsapps-user c=messaging p=0.5]
Thanks Borja.
Flags: needinfo?(gduan)
Comment on attachment 772010 [details]
https://github.com/mozilla-b2g/gaia/pull/10835

Taking this review!
Attachment #772010 - Flags: review?(schung) → review?(fbsc)
Comment on attachment 772010 [details]
https://github.com/mozilla-b2g/gaia/pull/10835

George, R+! Thanks for your patch :)
Attachment #772010 - Flags: review?(fbsc) → review+
Uplifted d0c9d97070ee6e46a2396e598b1123f0f7ac58c4 to:
v1-train: f5e809d3ee6f624cce7b35d72cf187f4fe2dada5
status-b2g18: --- → fixed
The options appear in the right place now.
Verified with unagi v1-train build: 
Gecko-2b310a1
Gaia-2e711c1
Status: RESOLVED → VERIFIED
Whiteboard: MMS_TEF, [u=commsapps-user c=messaging p=0.5] → MMS_TEF, [u=commsapps-user c=messaging p=0.5], [LeoVB+]
v1.1.0hd: f5e809d3ee6f624cce7b35d72cf187f4fe2dada5
status-b2g-v1.1hd: --- → fixed
removing ni to me as fixed/resolved/verified
Flags: needinfo?(aymanmaat)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: