890963 - Reword unclear string identity.mixed_active_loaded ("view website's behavior")

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Francesco Lodolo [:flod]]

identity.mixed_active_loaded=This website contains interactive content that isn't encrypted (such as scripts). Other people can view or modify the website's behavior.

Based on Metej's suggestion (see Bug 838402 comment 26)

This website contains interactive content that isn't encrypted (such as scripts). Other people can view the website or modify its behavior.

Note that the string ID must be updated too.

Comment 1

[Tanvi Vyas[:tanvi]]

Attachment: Update site identity message for Mixed Active Loaded v1

In bug 838402, we settled on "This page contains interactive content that isn't encrypted (such as scripts). Other people can view your information or modify the website's behavior".

Here is a patch that makes that string change.

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 777237 [details] [diff] [review]
Update site identity message for Mixed Active Loaded v1

Review of attachment 777237 [details] [diff] [review]:
-----------------------------------------------------------------

String's fine, but you'll be needing to update the code to look for the new property name, no?

Also, the current larry panel doesn't seem to wrap this string (and it's already hilariously too-wide, even in the current UI). Making it longer will likely overflow the screen. We'll need to fix that.

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Leon is getting laaaarger.

Comment 4

[Justin Dolske [:Dolske]]

Actually I guess the new string isn't actually significantly longer, but we really do need to make this wrap. Either this regressed or we missed it the first time around.

Comment 5

[Tanvi Vyas[:tanvi]]

The text doesn't seem to have ever wrapped.  I'm looking into how to do that.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Justin Dolske [:Dolske] from comment #3)
> Created attachment 780133 [details]
> Leon is getting laaaarger.

I thought his name was Larry. Is Leon his new friend?

Comment 7

[Tanvi Vyas[:tanvi]]

Attachment: Update site identity message for Mixed Active Loaded v2

It looks like there is no max-width for the identity box.  Adding a max-width so that the content will wrap.  I have set it to 50 characters, but could expand or decrease by a few characters if you think that would be better.

Also updated the code to look for the new property name.

Thanks Jared for your help!

Comment 8

[Tanvi Vyas[:tanvi]]

Attachment: Larry not so large anymore

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 783454 [details] [diff] [review]
Update site identity message for Mixed Active Loaded v2

Review of attachment 783454 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/linux/browser.css
@@ +1093,5 @@
>    max-width: 300px;
>  }
>  
> +#identity-popup-content-box {
> +  max-width:50ch;

nit: max-width: 50ch;

Move this to the bottom of identity-block.inc.css. Moving it to the bottom of identity-block.inc.css will mean that it doesn't need to be copied for each platform.

Comment 10

[Tanvi Vyas[:tanvi]]

Attachment: Update site identity message for Mixed Active Loaded v3

Updated per Jared's comments.

Comment 11

[Tanvi Vyas[:tanvi]]

Thanks for the review Jared!

Pushed to inbound:  https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8605750b68

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa8605750b68