Closed Bug 891042 Opened 6 years ago Closed 6 years ago

Gaia homescreen is not loading in firefox nightly

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: c= p=2)

Attachments

(2 files, 1 obsolete file)

Appears a recent gaia commit has broken the homescreen from loading within gaia.

Bisecting I found this as the breaking commit:

01649f946f087dcc1fa791659ad7eb50db4d9cb3 is the first bad commit
commit 01649f946f087dcc1fa791659ad7eb50db4d9cb3
Author: Edgar Chen <echen@mozilla.com>
Date:   Sun Jun 30 10:38:22 2013 +0800

    Bug 874769 - Use IccHelper to access card state. r=salva,etienne,arcturus,alive,arthurcc

:040000 040000 8cf37180b49cfb10186ef5698092df2820ae2a8f 83caa3b2b10700b2df6f293feeabcbcf9a945137 M	apps
:040000 040000 8d161bd64531548eb7100699561e479b23bd919f 26605dac1456e2dbd56b9b7c1df2b18521844afc M	shared
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: c= p=2
Attached file Github pull request pointer (obsolete) —
Comment on attachment 772232 [details]
Github pull request pointer

Etienne, Edgar - could one of you briefly review this simple change? Thanks!
Attachment #772232 - Flags: review?(etienne)
Attachment #772232 - Flags: review?(echen)
Comment on attachment 772232 [details]
Github pull request pointer

Arthur is more suitable than me to review this. :)
Attachment #772232 - Flags: review?(echen) → review?(arthur.chen)
Comment on attachment 772232 [details]
Github pull request pointer

Kevin, thanks for the patch. Please check my comment in github.
Attachment #772232 - Flags: review?(arthur.chen)
Arthur - Responded to github, let me know if you have any other concerns. We really need to land something for this asap as it's breaking workflow for a lot of developers.

I think we can land the simple fix, then investigate using a more full-fledged mock for a followup.
Let's do the simple fix. However, please make sure `IccHelpler.enabled` still works. It should return false if mozIccManager is undefined.
I am not sure is it a mockMobileConnection for desktop in tools/extensions/desktop-helper/content/data/lib/mobile_connection.js [1]. If so, maybe we could add a mockIccManager there.

[1] https://github.com/mozilla-b2g/gaia/blob/master/tools/extensions/desktop-helper/content/data/lib/mobile_connection.js
:kgrandon, could you help to try does this patch fix the issue? Thank in advance.
Flags: needinfo?(kgrandon)
Blocks: 877978
Edgar, thanks for the information!
Kevin, I tried to mock mozIccManager as expected. Then we can avoid the hack in IccHelper. Any comments?
Attachment #772559 - Flags: feedback?(kgrandon)
Attachment #772232 - Attachment is obsolete: true
Attachment #772232 - Flags: review?(etienne)
Comment on attachment 772559 [details]
link to https://github.com/mozilla-b2g/gaia/pull/10857

This looks great! Thank you for knocking this out.
Attachment #772559 - Flags: review+
Attachment #772559 - Flags: feedback?(kgrandon)
Attachment #772559 - Flags: feedback+
This has landed in master: https://github.com/mozilla-b2g/gaia/commit/82e6fd4b52223a8bcec0c78fc0b4aa4d0b1be0e0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.