891098 - Make the LoadThumbnailsTask static

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

LoadThumbnailsTask is accessing mTopBookmarks, that could be null when it gets detached from the window. This could cause an NPE. Make LoadThumbnailsTask to be independent of mTopBookmarks.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Done.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 772311 [details] [diff] [review]
Patch

Review of attachment 772311 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/BookmarksPage.java
@@ +328,5 @@
>          }
>  
>          @Override
>          public void onPostExecute(Map<String, Thumbnail> thumbnails) {
> +            if (mView.getHandler() != null) {

Please add a comment about this check (perhaps copy the one from https://hg.mozilla.org/projects/fig/file/tip/mobile/android/base/animation/PropertyAnimator.java#l208).

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/projects/fig/rev/84a315d4abda

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/84a315d4abda