891114 - b2g full emulator tests aren't runnable on try

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

https://bugzilla.mozilla.org/show_bug.cgi?id=890939#c3 :

> "try: -b do -p emulator -u all -t none" doesn't schedule any tests. For example:
https://tbpl.mozilla.org/?tree=Try&rev=25ae185b1b83

Comment 1

[Aki Sasaki (not active)]

I think I see the culprit:

In the builds, the platform is 'emulator':
http://hg.mozilla.org/build/buildbot-configs/file/ab58ece7515c/mozilla/b2g_config.py#l41

In the tests, the platform is 'b2g_emulator':
http://hg.mozilla.org/build/buildbot-configs/file/ab58ece7515c/mozilla-tests/b2g_config.py#l38

The reason?  Mozharness' sendchange() method prepends b2g_ to the platform.  I'm guessing this is historical, due to panda/b2g_panda or something.
http://hg.mozilla.org/build/mozharness/file/997d7d72d9ab/mozharness/mozilla/buildbot.py#l139

So:

* rename the test platform to 'emulator' (and 'emulator-debug')
* make sure no buildbot-test-builder names change
* modify mozharness' sendchange() to stop prepending b2g_ to the platform... since we're no longer running panda tests, this shouldn't be an issue (til we reenable panda tests?)
* make sure nothing breaks as a result of this

Comment 2

[Aki Sasaki (not active)]

Attachment: rename b2g_emulator -> emulator

No builder names changed because of this.

Comment 3

[Aki Sasaki (not active)]

Attachment: production-masters.json update

Comment 4

[Aki Sasaki (not active)]

Attachment: remove b2g_ from sendchange

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 772383 [details] [diff] [review]
production-masters.json update

https://hg.mozilla.org/build/tools/rev/6a764e44bdba

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 772382 [details] [diff] [review]
rename b2g_emulator -> emulator

https://hg.mozilla.org/build/buildbot-configs/rev/888fd1e26ef9

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 772384 [details] [diff] [review]
remove b2g_ from sendchange

https://hg.mozilla.org/build/mozharness/rev/8c919573883b

If this gets merged to production before the reconfig, we'll stop running full emulator tests til the next reconfig.

Comment 8

[Justin Wood (:Callek)]

In production

Comment 9

[Andrew Halberstadt [:ahal]]

This appeared to still not be working: https://tbpl.mozilla.org/?tree=Try&rev=5d7bec5acc14

Does it just need to wait for the reconfig?

Comment 10

[Aki Sasaki (not active)]

Hm, no.
I don't see a sendchange at all.  I'm going to guess we need something to enable those.

Comment 11

[Aki Sasaki (not active)]

Attachment: sendchange from try

Glad this doesn't need another reconfig.

Comment 12

[Aki Sasaki (not active)]

Comment on attachment 773481 [details] [diff] [review]
sendchange from try

callek irc r+

Comment 13

[Aki Sasaki (not active)]

Comment on attachment 773481 [details] [diff] [review]
sendchange from try

http://hg.mozilla.org/build/mozharness/rev/7a109ee611e0

Comment 14

[Aki Sasaki (not active)]

Crap,



14:26:13    ERROR - caught OS error 2: No such file or directory while running ['buildbot', 'sendchange', '--master', 'buildbot-master36.build.mozilla.org:9301', '--username', 'sendchange-unittest', '--branch', u'try-emulator-opt-unittest', '-r', u'24ba3db3f59ec7b53200196e84c7fc59f82ac75b', '--username', u'[e-mail]', '--comments', u'try: -b do -p all -u none -t none', '--property', u'builduid:1bd3b476e719478183397775137b4942', '--property', 'buildid:20130710161452', '--property', 'pgo_build:False', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-24ba3db3f59e/try-generic/emulator.tar.gz', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-24ba3db3f59e/try-generic/b2g-25.0a1.en-US.android-arm.tests.zip']

Comment 15

[Aki Sasaki (not active)]

Attachment: try sendchange take 2

Comment 16

[Aki Sasaki (not active)]

Comment on attachment 773585 [details] [diff] [review]
try sendchange take 2

Landed and merged as a bustage fix. http://hg.mozilla.org/build/mozharness/rev/42eaf82f376c

Comment 17

[Aki Sasaki (not active)]

Ok, so in https://tbpl.mozilla.org/?tree=Try&rev=5d7bec5acc14 , we have:

a) a build without a sendchange
b) a re-triggered build with a sendchange, but without buildbot in the PATH
c) a test triggered by copy/pasting the sendchange command with a working PATH
d) a re-re-triggered build that should have a sendchange, with an abspath to buildbot
e) we should have an automatically triggered 2nd test from (d) in a couple hours.

Comment 18

[Aki Sasaki (not active)]

Woot!

16:43:38     INFO - Running command: ['/tools/buildbot/bin/buildbot', 'sendchange', '--master', 'buildbot-master36.build.mozilla.org:9301', '--username', 'sendchange-unittest', '--branch', u'try-emulator-opt-unittest', '-r', u'5d7bec5acc147e183d51ee2413cdd1a4b63818f9', '--username', u'[e-mail]', '--comments', u'try: -b o -p emulator -u mochitest-1 -t none', '--property', u'builduid:af495b96fae74ce2aa48e6e1b59b6762', '--property', 'buildid:20130710183308', '--property', 'pgo_build:False', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-5d7bec5acc14/try-generic/emulator.tar.gz', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-5d7bec5acc14/try-generic/b2g-25.0a1.en-US.android-arm.tests.zip']
16:43:38     INFO - Copy/paste: /tools/buildbot/bin/buildbot sendchange --master buildbot-master36.build.mozilla.org:9301 --username sendchange-unittest --branch try-emulator-opt-unittest -r 5d7bec5acc147e183d51ee2413cdd1a4b63818f9 --username [e-mail] --comments "try: -b o -p emulator -u mochitest-1 -t none" --property builduid:af495b96fae74ce2aa48e6e1b59b6762 --property buildid:20130710183308 --property pgo_build:False http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-5d7bec5acc14/try-generic/emulator.tar.gz http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/try-builds/[e-mail]-5d7bec5acc14/try-generic/b2g-25.0a1.en-US.android-arm.tests.zip
16:43:40     INFO -  NOTE: --username/-u is deprecated: use --who/-W'
16:43:40     INFO -  change sent successfully

Comment 19

[Aki Sasaki (not active)]

I see a 2nd mochitest-1 run on :ahal's try push.