Closed
Bug 891161
Opened 10 years ago
Closed 10 years ago
about:apps page on FxAndroid has a marketplace link pointing to https://marketplace.mozilla.org , not https://marketplace.firefox.com
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: jsmith, Assigned: jsx)
Details
(Whiteboard: [good first bug][mentor=mfinkle@mozilla.com][lang=js])
Attachments
(2 files)
51.40 KB,
image/png
|
Details | |
844 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Build: Firefox 25 Nightly Device: Galaxy Nexus OS: Android 4.2 STR 1. Go to about:apps 2. Long press the marketplace link Expected The link should point to https://marketplace.firefox.com. Actual The link points to https://marketplace.mozilla.org.
Comment 1•10 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#473
Whiteboard: [good first bug][mentor=mfinkle@mozilla.com][lang=js]
Assignee | ||
Comment 2•10 years ago
|
||
I would like to get started with contributing code. I've no previous experience contributing code to Mozilla. Can I take this and work on this?
Assignee | ||
Comment 4•10 years ago
|
||
Thanks. As I said, this is my first time. So this might be a stupid question. Is there a git repo that I can clone and make the modification and send in a patch?
Comment 5•10 years ago
|
||
I suggest reading through https://wiki.mozilla.org/Mobile/Fennec/Android and first getting a build up and running that you can install to your device or emulator. Feel free to hop on to #mobile on irc.mozilla.org to chat with us and if you need assistance. https://developer.mozilla.org/en-US/docs/Developer_Guide Building Fennec: https://wiki.mozilla.org/Mobile/Fennec/Android#Building_Fennec Getting the source: https://wiki.mozilla.org/Mobile/Fennec/Android#Getting_the_source
Assignee | ||
Comment 6•10 years ago
|
||
Thanks for the detailed info Aaron. I'll do that.
Assignee | ||
Comment 7•10 years ago
|
||
I've made the change and created a pull request in Github. https://github.com/mozilla/mozilla-central/pull/15 Will this be ok? Or do I need to upload a patch?
Assignee | ||
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
We use Mercurial not the Github mirror, so the patch will need to be Mercurial based https://developer.mozilla.org/en-US/docs/Mercurial_FAQ
Assignee | ||
Updated•10 years ago
|
Attachment #773941 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 10•10 years ago
|
||
Is there anyway I can clone the just the 'mobile' directory from the repo rather than the entire mozilla-central repo?
Updated•10 years ago
|
Attachment #773941 -
Flags: review?(mark.finkle) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3556f19859
Keywords: checkin-needed
Assignee | ||
Comment 12•10 years ago
|
||
Is there any further action required from me? Because I got an email saying patch approved.
Comment 13•10 years ago
|
||
(In reply to Saurabh Nair [:jsx] from comment #12) > Is there any further action required from me? Because I got an email saying > patch approved. Nope. The patch was landed on mozilla-inbound and will make it's way to mozilla-central (and Nightly) soon. Thanks for the patch Saurabh. We hope you find another bug to work on next. Drop by #mobile on IRC if you want to talk about next bug opportunities.
Assignee | ||
Comment 14•10 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #13) > Drop by #mobile on IRC if you want to talk about next bug opportunities. Sure, I'll Mark. Thanks for all the help, Mark and Aaron.
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9f3556f19859
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•