891161 - about:apps page on FxAndroid has a marketplace link pointing to https://marketplace.mozilla.org, not https://marketplace.firefox.com

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Jason Smith [:jsmith]]

Attachment: Marketplace Link

Build: Firefox 25 Nightly
Device: Galaxy Nexus
OS: Android 4.2

STR

1. Go to about:apps
2. Long press the marketplace link

Expected

The link should point to https://marketplace.firefox.com.

Actual

The link points to https://marketplace.mozilla.org.

Comment 1

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#473

Comment 2

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

I would like to get started with contributing code. I've no previous experience contributing code to Mozilla. Can I take this and work on this?

Comment 3

[Aaron Train [:aaronmt]]

Sure thing.

Comment 4

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Thanks. As I said, this is my first time. So this might be a stupid question. Is there a git repo that I can clone and make the modification and send in a patch?

Comment 5

[Aaron Train [:aaronmt]]

I suggest reading through https://wiki.mozilla.org/Mobile/Fennec/Android and first getting a build up and running that you can install to your device or emulator. Feel free to hop on to #mobile on irc.mozilla.org to chat with us and if you need assistance.

https://developer.mozilla.org/en-US/docs/Developer_Guide

Building Fennec: https://wiki.mozilla.org/Mobile/Fennec/Android#Building_Fennec
Getting the source: https://wiki.mozilla.org/Mobile/Fennec/Android#Getting_the_source

Comment 6

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Thanks for the detailed info Aaron. I'll do that.

Comment 7

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

I've made the change and created a pull request in Github.

https://github.com/mozilla/mozilla-central/pull/15

Will this be ok? Or do I need to upload a patch?

Comment 8

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Attachment: Attaching patch

Comment 9

[Aaron Train [:aaronmt]]

We use Mercurial not the Github mirror, so the patch will need to be Mercurial based https://developer.mozilla.org/en-US/docs/Mercurial_FAQ

Comment 10

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Is there anyway I can clone the just the 'mobile' directory from the repo rather than the entire mozilla-central repo?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3556f19859

Comment 12

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Is there any further action required from me? Because I got an email saying patch approved.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Saurabh Nair [:jsx] from comment #12)
> Is there any further action required from me? Because I got an email saying
> patch approved.

Nope. The patch was landed on mozilla-inbound and will make it's way to mozilla-central (and Nightly) soon.

Thanks for the patch Saurabh. We hope you find another bug to work on next. Drop by #mobile on IRC if you want to talk about next bug opportunities.

Comment 14

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

(In reply to Mark Finkle (:mfinkle) from comment #13)
> Drop by #mobile on IRC if you want to talk about next bug opportunities.

Sure, I'll Mark. Thanks for all the help, Mark and Aaron.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f3556f19859