Unused ABOUT_HOME_URL constants

RESOLVED FIXED in Firefox 25

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: Roberta)

Tracking

Trunk
Firefox 25
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=java][mentor=mcomella][good-first-bug])

Attachments

(1 attachment)

There are some unused ABOUT_HOME_URL constants - see this MXR search for the instances: https://mxr.mozilla.org/mozilla-central/search?string=ABOUT_HOME_URL&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

These instances should be removed.
(Assignee)

Comment 1

4 years ago
Hi,
this seems an easy bug to start with, I'd like to fix it.
Sure and welcome to Bugzilla! I've assigned you to the bug.

Have you already set up a build environment? If not, you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
Assignee: nobody → r.deviti
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 772955 [details] [diff] [review]
Unused instances are removed.

Just a try to see if I'm on the right path.
Attachment #772955 - Flags: review?(michael.l.comella)
Comment on attachment 772955 [details] [diff] [review]
Unused instances are removed.

Review of attachment 772955 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM (looks good to me)! Nice work!

As mentioned here (https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree), you can add the "checkin-needed" keyword on this bug and someone should check in the patch for you. Soon after that your changes will appear in the Nightly builds!

If you're interested in contributing some more, you can find additional mentored bugs here (https://wiki.mozilla.org/Mobile/Get_Involved#Mentor_Bugs), or alternatively, you can find a fuller list of bugs through Bugs Ahoy! (http://www.joshmatthews.net/bugsahoy/?mobile=1) or various Bugzilla queries.

Finally, if you have any questions, again, feel free to ping me on IRC (mcomella) or just ask around #mobile.

Thanks and, again, welcome! :)
Attachment #772955 - Flags: review?(michael.l.comella) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
Done. Thanks for your help! :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef3c4558c3c
Flags: in-testsuite-
Keywords: checkin-needed

Comment 7

4 years ago
https://hg.mozilla.org/mozilla-central/rev/fef3c4558c3c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.