Last Comment Bug 891187 - Unused ABOUT_HOME_URL constants
: Unused ABOUT_HOME_URL constants
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: Firefox 25
Assigned To: Roberta
Depends on:
  Show dependency treegraph
Reported: 2013-07-08 18:07 PDT by Michael Comella (:mcomella)
Modified: 2013-07-11 03:07 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Unused instances are removed. (2.72 KB, patch)
2013-07-09 16:11 PDT, Roberta
michael.l.comella: review+
Details | Diff | Splinter Review

Description Michael Comella (:mcomella) 2013-07-08 18:07:01 PDT
There are some unused ABOUT_HOME_URL constants - see this MXR search for the instances:^[^\0]*%24&hitlimit=&tree=mozilla-central

These instances should be removed.
Comment 1 Roberta 2013-07-09 15:03:47 PDT
this seems an easy bug to start with, I'd like to fix it.
Comment 2 Michael Comella (:mcomella) 2013-07-09 15:12:01 PDT
Sure and welcome to Bugzilla! I've assigned you to the bug.

Have you already set up a build environment? If not, you can see the instructions here:

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see

Thanks and happy coding! ^_^
Comment 3 Roberta 2013-07-09 16:11:09 PDT
Created attachment 772955 [details] [diff] [review]
Unused instances are removed.

Just a try to see if I'm on the right path.
Comment 4 Michael Comella (:mcomella) 2013-07-09 16:27:59 PDT
Comment on attachment 772955 [details] [diff] [review]
Unused instances are removed.

Review of attachment 772955 [details] [diff] [review]:

LGTM (looks good to me)! Nice work!

As mentioned here (, you can add the "checkin-needed" keyword on this bug and someone should check in the patch for you. Soon after that your changes will appear in the Nightly builds!

If you're interested in contributing some more, you can find additional mentored bugs here (, or alternatively, you can find a fuller list of bugs through Bugs Ahoy! ( or various Bugzilla queries.

Finally, if you have any questions, again, feel free to ping me on IRC (mcomella) or just ask around #mobile.

Thanks and, again, welcome! :)
Comment 5 Roberta 2013-07-09 16:34:20 PDT
Done. Thanks for your help! :)
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-07-10 07:10:44 PDT
Comment 7 Ed Morley [:emorley] 2013-07-11 03:07:03 PDT

Note You need to log in before you can comment on or make changes to this bug.