891187 - Unused ABOUT_HOME_URL constants

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There are some unused ABOUT_HOME_URL constants - see this MXR search for the instances: https://mxr.mozilla.org/mozilla-central/search?string=ABOUT_HOME_URL&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

These instances should be removed.

Comment 1

[Roberta]

Hi,
this seems an easy bug to start with, I'd like to fix it.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sure and welcome to Bugzilla! I've assigned you to the bug.

Have you already set up a build environment? If not, you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 3

[Roberta]

Attachment: Unused instances are removed.

Just a try to see if I'm on the right path.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 772955 [details] [diff] [review]
Unused instances are removed.

Review of attachment 772955 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM (looks good to me)! Nice work!

As mentioned here (https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree), you can add the "checkin-needed" keyword on this bug and someone should check in the patch for you. Soon after that your changes will appear in the Nightly builds!

If you're interested in contributing some more, you can find additional mentored bugs here (https://wiki.mozilla.org/Mobile/Get_Involved#Mentor_Bugs), or alternatively, you can find a fuller list of bugs through Bugs Ahoy! (http://www.joshmatthews.net/bugsahoy/?mobile=1) or various Bugzilla queries.

Finally, if you have any questions, again, feel free to ping me on IRC (mcomella) or just ask around #mobile.

Thanks and, again, welcome! :)

Comment 5

[Roberta]

Done. Thanks for your help! :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fef3c4558c3c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fef3c4558c3c