891299 - [Dialer] String disapper when using keypad and hide.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Leo]

1. Title : String disapper when using keypad and hide.
2. Precondition : In call (emergency call, voicemail and withheld number)
3. Tester's Action : Show keypad >> Input number >> Hide keypad
4. Detailed Symptom : String disappear
5. Expected : String is shown
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduce
8. Gaia Revision : 0d5a9a7577f16b6a72a982148c6f509ee1714ea2
9. Personal email id : [e-mail]

Comment 1

[Leo]

Attachment: String disappear

Comment 2

[Leo]

Attachment: Pull Request URL 10859

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 772592 [details]
Pull Request URL 10859

Hi, the code looks good!

We just need to add unit tests for this.

You can look at the test here [1], and do something similar to test that |restorePhoneNumber()| works for witheld numbers and voicemail numbers too.

Thanks!

[1] https://github.com/leob2g/gaia/blob/4bb50b8ccc605aea038b7d3c15e6a63e6261f2cf/apps/communications/dialer/test/unit/handled_call_test.js#L599-606

Comment 4

[Leo]

Comment on attachment 772592 [details]
Pull Request URL 10859

I make unit test code.
Bug I'm not sure these test code.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 772592 [details]
Pull Request URL 10859

Thanks, those tests are great.

I commented on github with the last test missing (for ermegency number).

r=me with this test added!

Comment 6

[Leo]

(In reply to Etienne Segonzac (:etienne) from comment #5)
> Comment on attachment 772592 [details]
Pull Request URL 10859

Thanks, those
> tests are great.

I commented on github with the last test missing (for
> ermegency number).

r=me with this test added!

I add emergency unit test. Thanks for your help!

Comment 7

[Anthony Ricaud (:rik)]

Leo: Do you need someone with commit access to land this patch?

You can use the checkin-needed keyword when that is necessary.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(BTW, better to set the checkin-needed keyword rather than adding it to the whiteboard)

https://github.com/mozilla-b2g/gaia/commit/faf51f36abcec0a349ff44ab7a7de10fe0010314

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted faf51f36abcec0a349ff44ab7a7de10fe0010314 to:
v1-train: bdc8fb771f40efd15b9d49548061b80aa263a011