Open Bug 891476 Opened 6 years ago Updated 4 months ago

Let the lines from jar.mn land in chrome.manifest in the same order as they are in jar.mn

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: Paenglab, Unassigned)

References

Details

Attachments

(1 file)

During build the lines in jar.mn beginning with a % are written into the chrome.manifest. But unfortunately they are written in a random order.

For a unified XPI (one XPI for all platforms) of Lightning I need a fixed order of the skin assigning lines to give also non-main platforms the right skin directory.

The lines from jar.mn

% skin lightning classic/1.0 chrome/skin/linux/lightning/
% skin lightning classic/1.0 chrome/skin/osx/lightning/ os=Darwin
% skin lightning classic/1.0 chrome/skin/windows/lightning/ os=WINNT

are needed to be in this order but it happens often the first line lands as the last. This then breaks the themes for OS X and Windows.

I see no disadvantage for other lines in jar.mn when they are written in the original order.
Mike gave me over IRC this patch but unfortunately it didn't work.
Blocks: 882761
Attachment #772782 - Attachment is patch: true
Attachment #772782 - Attachment mime type: text/x-patch → text/plain
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.