Last Comment Bug 891544 - Remove unneeded FromUnknownPoint and FromUnknownRect calls
: Remove unneeded FromUnknownPoint and FromUnknownRect calls
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: 24 Branch
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla25
Assigned To: Botond Ballo [:botond]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 13:48 PDT by Kartikaya Gupta (email:kats@mozilla.com)
Modified: 2013-07-11 19:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.57 KB, patch)
2013-07-10 11:58 PDT, Botond Ballo [:botond]
bugmail: review+
Details | Diff | Splinter Review

Description Kartikaya Gupta (email:kats@mozilla.com) 2013-07-09 13:48:14 PDT
Some of the calls to *::FromUnknownPoint in AsyncPanZoomController.cpp were inserted early in the conversion process when converting from things that were gfx::Point. Now that those things have been converted over, we should be able to remove the FromUnknownPoint calls. For example, at [1] the TapGestureInput::mPoint has been converted, so the FromUnknownPoint there can be removed.

[1] https://hg.mozilla.org/mozilla-central/file/04d8c309fe72/gfx/layers/ipc/AsyncPanZoomController.cpp#l701
Comment 1 Botond Ballo [:botond] 2013-07-10 11:58:40 PDT
Created attachment 773451 [details] [diff] [review]
patch

Note: I didn't find any uses of FromUnknownRect that fit the bill. I also checked FromUnknownSize, and ToUnknown*, and again there was nothing.
Comment 2 Botond Ballo [:botond] 2013-07-11 07:06:13 PDT
Try results: https://tbpl.mozilla.org/?tree=Try&rev=5769c58c1064
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-07-11 07:46:06 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/32199b9444ca
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-07-11 19:07:41 PDT
https://hg.mozilla.org/mozilla-central/rev/32199b9444ca

Note You need to log in before you can comment on or make changes to this bug.