Last Comment Bug 891544 - Remove unneeded FromUnknownPoint and FromUnknownRect calls
: Remove unneeded FromUnknownPoint and FromUnknownRect calls
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: 24 Branch
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla25
Assigned To: Botond Ballo [:botond]
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2013-07-09 13:48 PDT by Kartikaya Gupta (
Modified: 2013-07-11 19:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (2.57 KB, patch)
2013-07-10 11:58 PDT, Botond Ballo [:botond]
bugmail: review+
Details | Diff | Splinter Review

Description User image Kartikaya Gupta ( 2013-07-09 13:48:14 PDT
Some of the calls to *::FromUnknownPoint in AsyncPanZoomController.cpp were inserted early in the conversion process when converting from things that were gfx::Point. Now that those things have been converted over, we should be able to remove the FromUnknownPoint calls. For example, at [1] the TapGestureInput::mPoint has been converted, so the FromUnknownPoint there can be removed.

Comment 1 User image Botond Ballo [:botond] 2013-07-10 11:58:40 PDT
Created attachment 773451 [details] [diff] [review]

Note: I didn't find any uses of FromUnknownRect that fit the bill. I also checked FromUnknownSize, and ToUnknown*, and again there was nothing.
Comment 2 User image Botond Ballo [:botond] 2013-07-11 07:06:13 PDT
Try results:
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2013-07-11 07:46:06 PDT
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2013-07-11 19:07:41 PDT

Note You need to log in before you can comment on or make changes to this bug.