Remove unneeded FromUnknownPoint and FromUnknownRect calls

RESOLVED FIXED in mozilla25

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: botond)

Tracking

24 Branch
mozilla25
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Some of the calls to *::FromUnknownPoint in AsyncPanZoomController.cpp were inserted early in the conversion process when converting from things that were gfx::Point. Now that those things have been converted over, we should be able to remove the FromUnknownPoint calls. For example, at [1] the TapGestureInput::mPoint has been converted, so the FromUnknownPoint there can be removed.

[1] https://hg.mozilla.org/mozilla-central/file/04d8c309fe72/gfx/layers/ipc/AsyncPanZoomController.cpp#l701
(Assignee)

Comment 1

4 years ago
Created attachment 773451 [details] [diff] [review]
patch

Note: I didn't find any uses of FromUnknownRect that fit the bill. I also checked FromUnknownSize, and ToUnknown*, and again there was nothing.
Attachment #773451 - Flags: review?(bugmail.mozilla)
Attachment #773451 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 2

4 years ago
Try results: https://tbpl.mozilla.org/?tree=Try&rev=5769c58c1064
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/32199b9444ca
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/32199b9444ca
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.