Closed Bug 891544 Opened 10 years ago Closed 10 years ago

Remove unneeded FromUnknownPoint and FromUnknownRect calls

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
24 Branch
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: kats, Assigned: botond)

Details

Attachments

(1 file)

patch
2.57 KB, patch
kats
: review+
Details | Diff | Splinter Review 
Some of the calls to *::FromUnknownPoint in AsyncPanZoomController.cpp were inserted early in the conversion process when converting from things that were gfx::Point. Now that those things have been converted over, we should be able to remove the FromUnknownPoint calls. For example, at [1] the TapGestureInput::mPoint has been converted, so the FromUnknownPoint there can be removed.

[1] https://hg.mozilla.org/mozilla-central/file/04d8c309fe72/gfx/layers/ipc/AsyncPanZoomController.cpp#l701
Attached patch patch — — Splinter Review 
Note: I didn't find any uses of FromUnknownRect that fit the bill. I also checked FromUnknownSize, and ToUnknown*, and again there was nothing.
Attachment #773451 - Flags: review?(bugmail.mozilla)
Attachment #773451 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/32199b9444ca
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.