891618 - [en-ZA] Search engine setup for Firefox Mobile for South African English

Status: RESOLVED FIXED

(Mozilla Localizations :: en-ZA / English (South Africa), defect)

Description

[Jeff Beatty [:gueroJeff]]

We want to ship Firefox Mobile with a good list of search engines for South African English.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Dwayne, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Dwayne, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Once we have a specification on what the search engines for en-ZA should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Dwayne, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The en-ZA team and Milos will be driving this bug to completion. 

We're aiming for inclusion into Firefox 25, which will be available in Aurora on August 6, 2013.

Comment 1

[Jeff Beatty [:gueroJeff]]

Hey Dwayne,

Since Fx25 is now in Aurora, do you have some time this week to look into search engines for Fennec?

Thanks,
Jeff

Comment 2

[Dwayne Bailey]

The suggested en-US set is fine for en-ZA i.e.:
Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Amazon is the only odd one out with most people using Kalahari which is stuck with bug 785908 which looked like it was Milos waiting for Kalahari to validate permission.  I sent a ping to Kalahari, if they ever do get back to us we can change it then.  For now en-US is fine.

Comment 3

[Jeff Beatty [:gueroJeff]]

(In reply to Dwayne Bailey from comment #2)
> The suggested en-US set is fine for en-ZA i.e.:
> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> desktop, 32x32 icon)
> 
> Amazon is the only odd one out with most people using Kalahari which is
> stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> validate permission.  I sent a ping to Kalahari, if they ever do get back to
> us we can change it then.  For now en-US is fine.

That being the case, I would suggest not shipping with Amazon. As I've learned from Axel, it's always better to add functionality than switch or replace it. The Swedish team is doing the same with a different commercial search engine. Would you be able to create a patch for this, attach it to the bug and flag flod to review it please?

Comment 4

[Jeff Beatty [:gueroJeff]]

(In reply to Dwayne Bailey from comment #2)
> The suggested en-US set is fine for en-ZA i.e.:
> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> desktop, 32x32 icon)
> 
> Amazon is the only odd one out with most people using Kalahari which is
> stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> validate permission.  I sent a ping to Kalahari, if they ever do get back to
> us we can change it then.  For now en-US is fine.

Hey Dwayne, Any word from Kalahari? Would love to get this resolved ASAP.

Comment 5

[Dwayne Bailey]

(In reply to jbeatty from comment #4)
> (In reply to Dwayne Bailey from comment #2)
> > The suggested en-US set is fine for en-ZA i.e.:
> > Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> > desktop, 32x32 icon)
> > 
> > Amazon is the only odd one out with most people using Kalahari which is
> > stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> > validate permission.  I sent a ping to Kalahari, if they ever do get back to
> > us we can change it then.  For now en-US is fine.
> 
> Hey Dwayne, Any word from Kalahari? Would love to get this resolved ASAP.

Tried to do some followup again.  But no response to my email and struggling to get through to someone technical

Comment 6

[Dwayne Bailey]

(In reply to Dwayne Bailey from comment #5)
> (In reply to jbeatty from comment #4)
> > (In reply to Dwayne Bailey from comment #2)
> > > The suggested en-US set is fine for en-ZA i.e.:
> > > Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> > > desktop, 32x32 icon)
> > > 
> > > Amazon is the only odd one out with most people using Kalahari which is
> > > stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> > > validate permission.  I sent a ping to Kalahari, if they ever do get back to
> > > us we can change it then.  For now en-US is fine.
> > 
> > Hey Dwayne, Any word from Kalahari? Would love to get this resolved ASAP.
> 
> Tried to do some followup again.  But no response to my email and struggling
> to get through to someone technical

One last push, trying to get an intro to the CTO so he can take it further.

Comment 7

[Jeff Beatty [:gueroJeff]]

(In reply to Dwayne Bailey from comment #6)
> (In reply to Dwayne Bailey from comment #5)
> > (In reply to jbeatty from comment #4)
> > > (In reply to Dwayne Bailey from comment #2)
> > > > The suggested en-US set is fine for en-ZA i.e.:
> > > > Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> > > > desktop, 32x32 icon)
> > > > 
> > > > Amazon is the only odd one out with most people using Kalahari which is
> > > > stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> > > > validate permission.  I sent a ping to Kalahari, if they ever do get back to
> > > > us we can change it then.  For now en-US is fine.
> > > 
> > > Hey Dwayne, Any word from Kalahari? Would love to get this resolved ASAP.
> > 
> > Tried to do some followup again.  But no response to my email and struggling
> > to get through to someone technical
> 
> One last push, trying to get an intro to the CTO so he can take it further.

Hey Dwayne,

I see that you have a pending sign-off on mobile. I'd rather wait to sign-off until this patch is landed in your repo. As mentioned before, it may be beneficial to simply create and land a patch without Kalahari (or Amazon, for that matter) first, and then add Kalahari at a subsequent release. Could you take care of that?

Comment 8

[Jeff Beatty [:gueroJeff]]

(In reply to Dwayne Bailey from comment #6)
> (In reply to Dwayne Bailey from comment #5)
> > (In reply to jbeatty from comment #4)
> > > (In reply to Dwayne Bailey from comment #2)
> > > > The suggested en-US set is fine for en-ZA i.e.:
> > > > Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to
> > > > desktop, 32x32 icon)
> > > > 
> > > > Amazon is the only odd one out with most people using Kalahari which is
> > > > stuck with bug 785908 which looked like it was Milos waiting for Kalahari to
> > > > validate permission.  I sent a ping to Kalahari, if they ever do get back to
> > > > us we can change it then.  For now en-US is fine.
> > > 
> > > Hey Dwayne, Any word from Kalahari? Would love to get this resolved ASAP.
> > 
> > Tried to do some followup again.  But no response to my email and struggling
> > to get through to someone technical
> 
> One last push, trying to get an intro to the CTO so he can take it further.

Hi Dwayne,

What's the status on this bug? Are we near a patch review? We're coming dangerously close to the deadline for 26

Comment 9

[Dwayne Bailey]

Attachment: Mobile search engine setup en-ZA

No response from Kalahari, I'll try again via their twitter feed.  SO for now lets take the advise of comment 3, thus this patch is the same as en-US but drops Amazon.  If we get some response from Kalahari we can slip it in, if not we can add Amazon with no disruption if I understand correctly.

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 820437 [details] [diff] [review]
Mobile search engine setup en-ZA

Review of attachment 820437 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks wrong (it adds a /searchplugins folder in the root, not in /mobile). 

Can you attach a complete patch? I guess this was just a diff on the file

Comment 11

[Dwayne Bailey]

Attachment: Mobile search engine setup en-ZA v2

Sorry about the first patch, more patch like this time.

Comment 12

[Francesco Lodolo [:flod]]

Comment on attachment 821666 [details] [diff] [review]
Mobile search engine setup en-ZA v2

Review of attachment 821666 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this works fine :-)

Comment 13

[Jeff Beatty [:gueroJeff]]

(In reply to Dwayne Bailey from comment #11)
> Created attachment 821666 [details] [diff] [review]
> Mobile search engine setup en-ZA v2
> 
> Sorry about the first patch, more patch like this time.

Hi Dwayne,

Do you have time this weekend to land this and kick off your sign off? This is the only blocker to release in the multi-locale build and it would be great to wrap it up.

Thanks,
Jeff

Comment 14

[Francesco Lodolo [:flod]]

Committed
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-ZA/rev/e04ac0b453ac
http://hg.mozilla.org/l10n-central/en-ZA/rev/e04ac0b453ac