Closed
Bug 891626
Opened 11 years ago
Closed 11 years ago
Inconsistent filename case for "ipc"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
1.88 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
widget/moz.build uses "IPC" (https://mxr.mozilla.org/mozilla-central/source/widget/moz.build#125)
ipc/glue.moz.build uses "ipc" (https://mxr.mozilla.org/mozilla-central/source/ipc/glue/moz.build#77)
There are also a few references to said files sprinkled around the tree which use different forms of casing. I think we've been OK up to this point because of case-insensitive file systems where these files are used. However, the Python code I'm writing in bug 890097 doesn't take too kindly to things.
Assignee | ||
Comment 1•11 years ago
|
||
I /think/ I caught all the references to "IPC" in the directory
component. "ipc" won out because it is more popular. If I didn't catch
them all, this at least made the patches I'm working on in bug 890097
stop complaining.
Attachment #772965 -
Flags: review?(benjamin)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gps
Comment 2•11 years ago
|
||
Comment on attachment 772965 [details] [diff] [review]
Consistent filename casing for "ipc"
This will almost certainly require a clobber...
Attachment #772965 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla25
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•