891643 - masterbranch argument to compare.py does nothing since bug 873034

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Matthew N. [:MattN]]

The comments in bug 873034 don't explain why the masterbranch code was being changed but it made it so that the masterbranch variable was never changed from the default value of "Firefox".

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Revert hunk from attachment 750426

Comment 2

[Matthew N. [:MattN]]

Attachment: v.2 Use options.masterbranch for compareResults

Actually, I think I like this approach better. Was there a reason we weren't using the "default" feature before?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 772990 [details] [diff] [review]
v.2 Use options.masterbranch for compareResults

Review of attachment 772990 [details] [diff] [review]:
-----------------------------------------------------------------

this is good stuff.  Why we were hardcoding Firefox, I think it was a shortcut and just ended up in the code base.  Going with defaults of Try/Firefox are good, that is what I see as the most generic usecase of compare.py.

Comment 4

[Matthew N. [:MattN]]

Thanks for the speedy reviews!
http://hg.mozilla.org/build/talos/rev/b6b6f9c1abcb