Closed
Bug 891643
Opened 12 years ago
Closed 12 years ago
masterbranch argument to compare.py does nothing since bug 873034
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
3.86 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
The comments in bug 873034 don't explain why the masterbranch code was being changed but it made it so that the masterbranch variable was never changed from the default value of "Firefox".
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #772974 -
Flags: review?(jmaher)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Actually, I think I like this approach better. Was there a reason we weren't using the "default" feature before?
Attachment #772974 -
Attachment is obsolete: true
Attachment #772974 -
Flags: review?(jmaher)
Attachment #772990 -
Flags: review?(jmaher)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 772990 [details] [diff] [review]
v.2 Use options.masterbranch for compareResults
Review of attachment 772990 [details] [diff] [review]:
-----------------------------------------------------------------
this is good stuff. Why we were hardcoding Firefox, I think it was a shortcut and just ended up in the code base. Going with defaults of Try/Firefox are good, that is what I see as the most generic usecase of compare.py.
Attachment #772990 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Thanks for the speedy reviews!
http://hg.mozilla.org/build/talos/rev/b6b6f9c1abcb
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•